Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localized Strings #2335

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 6, 2023

Automatically created by zacwest.

@zacwest zacwest force-pushed the create-pull-request/download_strings branch 2 times, most recently from 452ba6d to 37316f3 Compare April 13, 2023 06:03
@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 37316f3 to 341b303 Compare April 21, 2023 06:04
@bgoncal
Copy link
Member

bgoncal commented Nov 2, 2023

@zacwest I see this is from April, can we close it?

@zacwest
Copy link
Member

zacwest commented Nov 2, 2023

No, this still needs to run. I think I added another language and the recurring Fastlane lane is failing - see the actions tab here - making this out of date. But this is the flow whereby our translations update.

They need to go through PR (rather than just directly committing) because Lokalize can't guarantee we won't have regressions in the Intents translation parameters, which the unit tests cover.

@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 341b303 to b0b0b8e Compare November 28, 2023 23:05
Copy link

emerge-tools bot commented Nov 28, 2023

1 build increased size

Name Version Download Change Install Change
Home Assistant
io.robbie.HomeAssistant
2023.12 (2023.2821) 35.2 MB ⬆️ 76.5 kB (0.22%) 81.8 MB ⬆️ 221.4 kB (0.28%)

Home Assistant 2023.12 (2023.2821)
io.robbie.HomeAssistant

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 221.4 kB (0.28%)
Total download size change: ⬆️ 76.5 kB (0.22%)

Largest size changes

Item Install Size Change
Localizable.strings ⬆️ 20.5 kB
Localizable.strings ⬆️ 20.5 kB
Localizable.strings ⬆️ 12.3 kB
Localizable.strings ⬆️ 12.3 kB
Localizable.strings ⬆️ 8.2 kB

Image of diff


🛸 Powered by Emerge Tools

@zacwest zacwest force-pushed the create-pull-request/download_strings branch 7 times, most recently from b65d5af to 23814e2 Compare December 6, 2023 18:49
@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 39435f0 to 095d671 Compare December 8, 2023 06:03
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdc2f14) 28.13% compared to head (095d671) 28.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2335   +/-   ##
=======================================
  Coverage   28.13%   28.13%           
=======================================
  Files         285      285           
  Lines       30784    30784           
=======================================
  Hits         8661     8661           
  Misses      22123    22123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 9b2c7ad into master Dec 8, 2023
7 checks passed
@bgoncal bgoncal deleted the create-pull-request/download_strings branch December 8, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants