Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backup to installation independent section of common tasks #36679

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

c0ffeeca7
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 commented Jan 3, 2025

Proposed change

Move backup to installation independent section of common tasks

  • as backup and backup restore steps are installation independent

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration others were adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation

    • Updated backup-related links across multiple documentation pages to point to a more general backup section
    • Consolidated backup documentation under a new general category
    • Added backup sections to container and core documentation
    • Restructured redirect mappings for improved navigation
  • Chores

    • Removed backup-specific inclusions from OS and Supervised documentation
    • Added new redirects for community resources and integration pages

@c0ffeeca7 c0ffeeca7 requested a review from a team as a code owner January 3, 2025 15:15
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 3, 2025
Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

📝 Walkthrough

Walkthrough

The changes involve a comprehensive documentation restructuring focused on backup-related links across multiple Home Assistant documentation files. The primary modification is shifting backup documentation references from an operating system-specific context (/common-tasks/os/#backups) to a more generalized location (/common-tasks/general/#backups). This update affects various documentation pages, redirects, and installation method descriptions, ensuring consistent and centralized backup guidance across different Home Assistant installation types.

Changes

File Change Summary
source/_docs/configuration.markdown Updated backup documentation link from OS-specific to general context
source/_includes/common-tasks/data_disk.md Modified backup link in migration instructions
source/_includes/common-tasks/update.md Updated backup link for update instructions
source/_integrations/backup.markdown Revised backup documentation reference link
source/_redirects Added multiple redirects, including backup-related redirects
source/common-tasks/container.markdown Added new "Backup" section
source/common-tasks/core.markdown Added new "Backup" section
source/common-tasks/general.markdown Included backups.md file
source/common-tasks/os.markdown Removed backups.md file inclusion
source/common-tasks/supervised.markdown Removed backups.md file inclusion
source/getting-started/configuration.markdown Updated backup links for different installation methods
source/installation/index.html Updated backup link in installation methods comparison

Sequence Diagram

sequenceDiagram
    participant User
    participant Docs
    participant BackupSection

    User->>Docs: Access backup documentation
    Docs->>BackupSection: Redirect to general backup section
    BackupSection-->>User: Provide backup instructions
Loading

The sequence diagram illustrates the new documentation flow, where users are consistently directed to a centralized, general backup documentation section, regardless of their Home Assistant installation method.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 2a7e2b3
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6777ff157a685900095d84e2
😎 Deploy Preview https://deploy-preview-36679--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_includes/common-tasks/update.md (1)

3-3: Use the correct verb form for clarity in step-by-step instructions.
"Backup" is typically used as a noun; in an imperative statement, use “Back up” to avoid confusion.

- 1. Backup your installation...
+ 1. Back up your installation...
🧰 Tools
🪛 LanguageTool

[grammar] ~3-~3: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...e for updating Home Assistant Core: 1. Backup your installation{% if page.installatio...

(SENT_START_BACKUP)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e0c64e and 2a7e2b3.

📒 Files selected for processing (13)
  • source/_docs/configuration.markdown (1 hunks)
  • source/_includes/common-tasks/data_disk.md (1 hunks)
  • source/_includes/common-tasks/specific_version.md (1 hunks)
  • source/_includes/common-tasks/update.md (1 hunks)
  • source/_integrations/backup.markdown (1 hunks)
  • source/_redirects (1 hunks)
  • source/common-tasks/container.markdown (1 hunks)
  • source/common-tasks/core.markdown (1 hunks)
  • source/common-tasks/general.markdown (1 hunks)
  • source/common-tasks/os.markdown (0 hunks)
  • source/common-tasks/supervised.markdown (0 hunks)
  • source/getting-started/configuration.markdown (2 hunks)
  • source/installation/index.html (1 hunks)
💤 Files with no reviewable changes (2)
  • source/common-tasks/supervised.markdown
  • source/common-tasks/os.markdown
✅ Files skipped from review due to trivial changes (3)
  • source/common-tasks/container.markdown
  • source/common-tasks/core.markdown
  • source/_includes/common-tasks/data_disk.md
🧰 Additional context used
📓 Path-based instructions (1)
source/_redirects (6)

Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

Pattern */**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"


Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.


Pattern */**(html|markdown|md): do not comment on HTML used for icons


Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

🪛 LanguageTool
source/_includes/common-tasks/update.md

[grammar] ~3-~3: The word ‘Backup’ is a noun. Do you mean the verb “Back up”?
Context: ...e for updating Home Assistant Core: 1. Backup your installation{% if page.installatio...

(SENT_START_BACKUP)

🔇 Additional comments (8)
source/_redirects (1)

403-405: Double-check consistency of snapshot vs. backup terminology.
Lines 403, 404, and 405 replace “snapshots” references with “backups.” Confirm that all references to “snapshots” throughout the codebase and documentation remain consistent with these adjustments and do not create user confusion or redirect loops.

✅ Verification successful

Based on the search results, I can provide the final response as there is sufficient context to verify the concern about snapshot vs. backup terminology consistency.

Terminology change from "snapshots" to "backups" is consistent with codebase

The redirects in lines 403-405 that change references from "snapshots" to "backups" are consistent with the codebase. The search results show that the term "snapshot" is primarily used in different contexts:

  1. Test snapshots - Used extensively throughout the codebase for testing purposes
  2. Camera snapshots - Used specifically for camera/image functionality
  3. Stream snapshots - Used for video streaming features

The redirects specifically change documentation paths from /common-tasks/os/#snapshots and /common-tasks/supervised/#snapshots to /common-tasks/general/#backups, which appears to be an intentional standardization of backup-related terminology in the documentation. There are no other instances found where "snapshots" is used in the context of system backups that would need to be updated.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any references to "snapshot" that might need updating:
rg -A 3 -i 'snapshot'

Length of output: 73604

source/_includes/common-tasks/specific_version.md (1)

23-23: Good alignment with the new general backup section.
The link now points to a more general location for backups, which aligns with installation-independent steps.

source/common-tasks/general.markdown (1)

8-9: New backup reference included.
Adding {% include common-tasks/backups.md %} provides a centralized place for backup procedures, improving cross-installation guidance.

source/getting-started/configuration.markdown (2)

11-11: Link updated to the new backup section.
This updated link is aligned with the generalizing effort for backup documentation.


43-44: Rebranded references to general backup documentation.
These items are consistent with the new universal backup section, ensuring uniform guidance.

source/_integrations/backup.markdown (1)

26-26: LGTM! Link update aligns with documentation restructuring.

The change correctly updates the reference to the backup documentation, making it installation-method independent.

source/_docs/configuration.markdown (1)

9-9: LGTM! Documentation reference properly updated.

The related documentation link has been correctly updated to point to the installation-independent backup section.

source/installation/index.html (1)

335-335: LGTM! Installation comparison table properly updated.

The backup feature link in the installation comparison table has been correctly updated to reference the general backup section. The associated footnotes maintain accurate information about backup capabilities across different installation methods.

@frenck frenck added this to the 2025.1 milestone Jan 3, 2025
@frenck frenck merged commit b227579 into next Jan 3, 2025
9 checks passed
@frenck frenck deleted the move-backup-to-general-tasks branch January 3, 2025 15:26
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Jan 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants