-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SensorPush Cloud integration #36600
base: next
Are you sure you want to change the base?
Add SensorPush Cloud integration #36600
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new documentation file for the SensorPush Cloud integration has been added to the Home Assistant documentation repository. The CODEOWNERS file was simultaneously updated to assign Changes
Sequence DiagramsequenceDiagram
participant User
participant SensorPush App
participant Gateway Cloud Dashboard
participant Home Assistant
User->>SensorPush App: Activate devices
User->>Gateway Cloud Dashboard: Enable API access
User->>Home Assistant: Configure SensorPush Cloud integration
Home Assistant->>SensorPush App: Authenticate and fetch device data
SensorPush App-->>Home Assistant: Return sensor measurements
Home Assistant->>User: Display environmental sensor data
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (5)CODEOWNERS (1)
Adding yourself as codeowner for the SensorPush Cloud documentation ensures proper oversight and maintenance. This entry is straightforward and follows the established pattern. source/_integrations/sensorpush_cloud.markdown (4)
While the metadata block is well-structured, the release version is set to "2025.1," which is quite far in the future. Confirm that this version aligns with Home Assistant’s planned release schedule.
The prerequisites are comprehensively stated, guiding users through necessary setup steps before integration. Good job providing relevant links to the SensorPush app and Gateway Cloud Dashboard.
The references to official product pages and the mention of the G1 WiFi Gateway requirement should help users identify hardware compatibility quickly.
Providing a detailed breakdown, including which sensors are disabled by default, is helpful. The note for HT1 series devices is also clearly stated. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Proposed change
This PR adds cloud integration for SensorPush devices. It communicates with the publicly available Cloud API using the sensorpush-api and sensorpush-ha Python packages. Care was taken to ensure that presented devices appeared the same as those created by the existing SensorPush integration. A G1 WiFi Gateway is required to make use of the Cloud API.
Note
This PR is a re-submission of home-assistant/core#121890, which fixes several issues reported by reviewers. I would like to send a heartfelt apology to @joostlek, @edenhaus, and @frenck - I was caught between dueling schedules and I wasn't able to do the work needed to get it over the finish line. I was finally able to put in the time over the holiday break to make requested changes in addition to improved unit tests, strict typing, async dependencies, and websession injection (whew!)
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation