-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi textfield helper #23649
base: dev
Are you sure you want to change the base?
Multi textfield helper #23649
Conversation
The helper seems a little out of place because of the button. I will ask UX team to know how we can fix that. |
@karwosts I've made a design that addresses this PR, along with some other much needed fixes for this whole dialog. Feel free to include it also or not. |
@marcinbauer85 - This bug is not specifically for history stats, but regarding the lack of This form in my screenshot is not specific to history stats, it is just an example of a config flow form. You design omits Most of these changes you request would therefore be ha/core changes to the config flow schema for history_stats, which is out of scope for this PR. |
@karwosts Thanks for letting me know. The bugs are just something I've noticed and can be addressed by a seperate PR in the future. Helper text should be used only when validation is triggered on that specific selector, so in this case if triggered it would show up under the selector itself, not at the end, or under the "+ADD STATE") button. |
Sorry, this is hard for me to believe. Every other selector shows the description field. You're saying just for multiple-textfield selectors you don't want to show it? Or you want it to be removed for every selector from every integration? Not every field may even have possible validation, it may just be freeform input that needs explanation. |
For now please just align the "Add state" button to the left. In the future we'll tackle other UX issues of this helper and others. |
Co-authored-by: Bram Kragten <[email protected]>
Thank you Marcin, it has been left aligned. |
Proposed change
Add helper text, and add label to
ADD
button. Sometimes there is no textbox visible, so the label would not otherwise be visible.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: