Don't hide location entities that are "home" in the MapViewStrategy #23462
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I've discovered that the
MapViewStrategy
that populates the defaultmap
dashboard filters any entity that is "home" no matter if it has geolocation data. Checking the history, I can see that this is how it always worked:https://github.com/home-assistant/frontend/blame/7542c03dbbfd64e20dbc061ab6d271d4aec8a76a/src/panels/map/ha-panel-map.ts#L61-L87
I'd like to challenge that, because to me, it is very confusing.
I first thought that maybe my android companion app was misconfigured, because even though I enabled my location, I just couldn't see anything. There was simply no feedback excluding maybe the devtools where my
person
entity suddenly gainedlatitude
/longitude
attributes.I was considering that maybe I'm supposed to "Take Control" of the Map dashboard, however that also seemed wrong so I started digging and eventually found that filter.
Another inconsistency about this filter is that the
person
marker will show up while in any other configured zone (e.g.work
,school
, etc.) but not whilehome
.Type of change
Example configuration
Default config
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: