Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent "More info" for To-do-lists #23459

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NoRi2909
Copy link
Contributor

When you select "Information" from the three-dot menu of a To-do list or Shopping list

Screenshot 2024-12-26 15 46 22

this actually opens the "More info" dialog:

Screenshot 2024-12-26 15 53 29

Therefore the menu item needs to use the same consistent term here like we have for Interactions in the Dashboard:

image

Proposed change

Replace "Information" with "More info" for a consistent terminology.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

When you select "Information" from the three-dot menu of a To-do list or Shopping list this actually opens the "More info" dialog.

Therefore the menu item needs to use the same consistent term here.
@NoRi2909 NoRi2909 marked this pull request as ready for review December 26, 2024 15:19
@MindFreeze
Copy link
Contributor

hmm, we also use "Information" in the automation/script/scene overflow menu

@NoRi2909
Copy link
Contributor Author

Good point, I also have the same issue with that menu item, too.

Having "More info" in all those places should help in showing that it's that dialog which comes up.
"Information" is such a general term that is used in so, so many places.

On a Mac it's similar with the "Get Info" window for files, folders and volumes that is always referred to by that name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants