Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing localizations for Voice Assistants > Expose headers #23452

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

NoRi2909
Copy link
Contributor

Proposed change

The Icon and the Remove columns of the Expose tab for Settings > Voice Assistants are lacking localizable labels so they show up with their lowercase variable names only:

image

This PR adds two string definitions to en.json and the necessary code to ha-config-voice-assistants-expose.ts

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Dec 29, 2024

@silamon Edit: Now I figured it out …

As long as everything fits in 80 chars it wants everything on a single line, with one character more it has to be split into several lines. Learning something new every day …

@NoRi2909 NoRi2909 marked this pull request as ready for review December 29, 2024 21:07
@MindFreeze MindFreeze merged commit ff75c89 into home-assistant:dev Jan 6, 2025
15 checks passed
@bramkragten bramkragten added this to the 2025.1 milestone Jan 6, 2025
bramkragten pushed a commit that referenced this pull request Jan 6, 2025
* Add missing localizations for Voice Assistants > Expose headers

* Add localizable labels to Icon and Remove columns

* Variant with all changes on a single line

* Prettier?

* Revert

* Line length limited to 80 chars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants