Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup translations #23365

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add backup translations #23365

wants to merge 1 commit into from

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • add all backup translations

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

"media_description": "For example, camera recordings.",
"share_folder": "Share folder",
"share_folder_description": "Folder that is often used for advanced or older configurations.",
"local_addons": "Local addons folder",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be "Local add-ons folder"?

You used the hyphen in all other strings.

@NoRi2909
Copy link
Contributor

On the main page the header does not seem to get localized, yet:

Also this should be "Backups" (plural) like on the subpages and matching the caption in /config/system

Perhaps something to add to this PR.

@bramkragten
Copy link
Member

This PR is far from complete, backups are mostly untranslated atm

@NoRi2909
Copy link
Contributor

@bramkragten Yes, I just wanted to make sure that this singular vs. plural issue is addressed along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants