Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document API behaviour for service response data #2137

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

iamjackg
Copy link

@iamjackg iamjackg commented Apr 6, 2024

Proposed change

Adds documentation for a new query/JSON parameter called return_response. It allows users to retrieve service response data instead of state changes when calling a service using the API.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

Summary by CodeRabbit

  • Documentation
    • Refined descriptions of returned states during service execution.
    • Improved clarity on service response data, including examples of JSON response formats.
    • Added tips and notes for better handling of service responses and data retrieval.
    • Introduced a new curl command example for retrieving daily weather forecast information.

Adds documentation for a new query/JSON parameter called `return_response`. It allows users to retrieve service response data instead of state changes when calling a service using the API.
@iamjackg
Copy link
Author

According to home-assistant/architecture#1074, the REST API is no longer supported. Closing this.

@iamjackg iamjackg closed this Apr 23, 2024
@iamjackg iamjackg reopened this Jun 21, 2024
@iamjackg
Copy link
Author

Reopened as home-assistant/core#115046 is making progress again.

Copy link
Contributor

coderabbitai bot commented Jun 21, 2024

Walkthrough

Walkthrough

The updates to the rest.md API documentation enhance clarity regarding service execution and responses. They refine the description of changed states and introduce detailed information on service response data, including new examples and guidance notes for users. Additionally, a curl command example has been added to demonstrate how to retrieve specific data.

Changes

Files Change Summary
docs/api/rest.md Clarified return statement regarding changed states, added details on response data retrieval with the ?return_response parameter, incorporated JSON response examples, and included user guidance notes and a new curl command example.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 74c03c6 and 5d9b6a8.

Files selected for processing (1)
  • docs/api/rest.md (3 hunks)
Additional comments not posted (5)
docs/api/rest.md (5)

639-639: Approved: Clear explanation of default API call behavior.

The added documentation effectively clarifies that by default, a call will return a list of states that have changed while the service was being executed.


658-660: Approved: Useful tip about API call result.

The tip provides valuable information about the result including any states that changed during the service execution.


662-701: Approved: Clear explanation and example of return_response parameter.

The added documentation clearly explains the return_response parameter and provides a valuable example of the expected JSON response.


703-707: Approved: Important note on service behavior and error handling.

The note provides crucial information about the behavior of services and error handling when using the return_response parameter.


746-754: Approved: Practical example of using return_response parameter.

The sample curl command provides a clear and practical example of using the return_response parameter to retrieve daily weather forecast information.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

docs/api/rest.md Show resolved Hide resolved
docs/api/rest.md Outdated
Comment on lines 706 to 707
If you don't use `return_response` when calling a service that must return data, the API will return an error. Similarly, you will receive an error if you use `return_response` when calling a service that doesn't return any data.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve error handling documentation for return_response.

The note about receiving an error if return_response is misused is crucial. Clarify what types of errors users can expect (e.g., HTTP status codes) to improve their ability to handle these cases programmatically.

+ For example, using `return_response` incorrectly might result in a `400 Bad Request` error, indicating that the parameter was not expected for the called service.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
If you don't use `return_response` when calling a service that must return data, the API will return an error. Similarly, you will receive an error if you use `return_response` when calling a service that doesn't return any data.
:::
If you don't use `return_response` when calling a service that must return data, the API will return an error. Similarly, you will receive an error if you use `return_response` when calling a service that doesn't return any data.
For example, using `return_response` incorrectly might result in a `400 Bad Request` error, indicating that the parameter was not expected for the called service.
:::

},
{
"attributes": {},
"entity_id": "process.Dropbox",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"entity_id": "process.Dropbox",
"entity_id": "binary_sensor.dropbox",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All entities in the state machine should always be lower case

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's copy-pasted from another example in this same document.

"entity_id": "process.Dropbox",

"entity_id": "process.Dropbox",

Are those wrong too? They look like very old examples, if the date in the sample data is to be believed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants