-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add battery sensor to ohme #134222
Add battery sensor to ohme #134222
Conversation
key="battery", | ||
native_unit_of_measurement=PERCENTAGE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use translation keys to mention that this is for the connected vehicle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if the vehicle is disconnected, what does it show
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. When nothing is connected it'll either:
- Still show the up to date battery % - if you've linked the car with the charger in the manufacturers app,
or - Show the amount of charge added in the last session - if no car is linked
Either way, its showing what you would get if you looked in the Ohme app, charging or not.
Oops forgot to update those snapshots. Also changed car to vehicle, seems like a better term as it could be a van/some other vehicle. |
Proposed change
Add battery sensor to Ohme. Not too sure on the approach here as the battery is actually for the connected car rather than the device itself...
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: