Added LK Systems floor heating integration #134188
Draft
+481
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-needed
has-tests
new-integration
integration: lk_systems
labels
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
quality-scale
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
zweckj
requested changes
Dec 29, 2024
Comment on lines
+48
to
+81
| class LKWebServerAPI: | ||
| """An API client for the LK Systems webserver.""" | ||
|
|
||
| def __init__(self, email, password) -> None: | ||
| """Initialize the API client.""" | ||
| self.base_url = "https://my.lk.nu" | ||
| self.email = email | ||
| self.password = password | ||
| self.session = None | ||
|
|
||
| async def login(self): | ||
| """Log in to the LK Systems API and initialize the session.""" | ||
| if self.session is None: | ||
| self.session = aiohttp.ClientSession() | ||
|
|
||
| login_url = f"{self.base_url}/login" | ||
| payload = {"email": self.email, "password": self.password} | ||
| async with self.session.post(login_url, data=payload) as response: | ||
| response.raise_for_status() | ||
| result = await response.json() | ||
| if result.get("error") == "1": | ||
| _LOGGER.error("Login failed: %s", result.get("msg", "Unknown error")) | ||
| raise InvalidAuth(result.get("msg", "Access denied.")) | ||
|
|
||
| async def get_main_data(self): | ||
| """Fetch the main data from the LK Systems webserver.""" | ||
| url = f"{self.base_url}/main.json" | ||
| if self.session is None: | ||
| return {} | ||
| async with self.session.get(url) as response: | ||
| response.raise_for_status() | ||
| return await response.json() | ||
|
|
||
| async def set_room_temperature(self, zone_id, temperature) -> dict: |
There was a problem hiding this comment.
library code (this) needs to be place in a public git repository, together with an OSI approved license, needs to be pushed to PyPi through CICD and installed from there in HA
There was a problem hiding this comment.
Okay I see. Too much work for me. Hopefully someone can follow this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: