Push Overseerr updates via webhook #134187
Conversation
| | NotificationType.REQUEST_PROCESSING_FAILED | ||
| | NotificationType.REQUEST_AUTOMATICALLY_APPROVED | ||
| ) | ||
| JSON_PAYLOAD = ( |
There was a problem hiding this comment.
how HA specific is this/could this be generated in the lib based on notification types as input (tbh I don't really love having this here)
There was a problem hiding this comment.
So Overseerr has the option to shape the webhook however you want. And I don't really think that this is part of the library, as the library does not consume the webhook but HA does
There was a problem hiding this comment.
I get that, I was thinking about moving that shaping part to the lib, just so we don’t handle raw json here. Can we at least prettify the formatting (triple string) if it stays here for readability?
There was a problem hiding this comment.
The fun part is that I removed all space in between, as apparently overseerr seems to mess with spaces.
But I think moving the shape to the library leaves you still with a mess because how are you going to shape parameters for that
There was a problem hiding this comment.
was thinking about passing lists per top level key since it's always key: {{key}}
There was a problem hiding this comment.
exactly, that's why I said per top level key as those are different
There was a problem hiding this comment.
But someone can wish to have a different layout and not have these keys there
There was a problem hiding this comment.
I get that, was just looking for a way to avoid a large raw json block here
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Push Overseerr updates via webhook. We try to setup the webhook during setup of the integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: