Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SensorPush Cloud integration #134181

Closed

Conversation

sstallion
Copy link

@sstallion sstallion commented Dec 29, 2024

Proposed change

This PR adds cloud integration for SensorPush devices. It communicates with the publicly available Cloud API using the sensorpush-api and sensorpush-ha Python packages. Care was taken to ensure that presented devices appeared the same as those created by the existing SensorPush integration. A G1 WiFi Gateway is required to make use of the Cloud API.

Note: This PR is a re-submission of #121890, which fixes several issues reported by reviewers. I would like to send a heartfelt apology to @joostlek, @edenhaus, and @frenck - I was caught between dueling schedules and I wasn't able to do the work needed to get it over the finish line. I was finally able to put in the time over the holiday break to make requested changes in addition to improved unit tests, strict typing, async dependencies, and websession injection (whew!)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

  1. Remove deprecated yaml import from pyLoad integration #134200
  2. Remove deprecated yaml import from OTP integration #134196

@sstallion sstallion marked this pull request as ready for review December 29, 2024 17:32
@sstallion sstallion force-pushed the sstallion/sensorpush_cloud branch from b7d4ce0 to 1afc794 Compare December 29, 2024 17:34
@sstallion
Copy link
Author

sstallion commented Dec 29, 2024

Apologies, I updated the branch and that seems to have caused issues with assigning reviewers. I will put this back into draft while I clean up the mess.

@sstallion sstallion marked this pull request as draft December 29, 2024 17:37
@sstallion sstallion force-pushed the sstallion/sensorpush_cloud branch from 1afc794 to b7d4ce0 Compare December 29, 2024 17:40
@sstallion sstallion marked this pull request as ready for review December 29, 2024 17:42
@sstallion
Copy link
Author

Done. Again, I apologize for the faux pas. Unfortunately, I do not have permission to remove reviewers - I would appreciate it if someone could fix this to prevent additional spam.

@sstallion
Copy link
Author

Closing to repair and resubmit. It appears that GitHub introduced a merge rather than a rebase for some reason.

@sstallion sstallion closed this Dec 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant