Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto select thermostat preset when selecting temperature #134146

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

domingues
Copy link

@domingues domingues commented Dec 28, 2024

Proposed change

The selected preset of the generic thermostat should reflect the selected temperature.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domingues

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft December 28, 2024 13:26
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @domingues 👋

THanks for opening a PR, however, it seems that the PR template got lost / partially removed. Could you please restore it and fill it out?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 31, 2024 22:22
@domingues
Copy link
Author

domingues commented Jan 2, 2025

Hi there @domingues 👋

THanks for opening a PR, however, it seems that the PR template got lost / partially removed. Could you please restore it and fill it out?

Thanks! 👍

../Frenck

Sorry for that. Is ok now, I think.

PS: Bug or feature?
I consider this a bug, but if for some reasons that I'm not aware this is considered a breaking change, we can transform this in a non breaking feature just adding a new setting to the integration "keep_preset_in_sync_with_temperate".

@domingues domingues marked this pull request as ready for review January 2, 2025 14:33
@home-assistant home-assistant bot requested a review from frenck January 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants