Add FlexMeasures integration #100110
Add FlexMeasures integration #100110
Conversation
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
…server, which triggers a FlexMeasuresClient stub
… a URL to an aiohttp websockets server. This is based on the integration websockets_api. Signed-off-by: victor <[email protected]>
Signed-off-by: victor <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Start flexmeasures integration for ha
…s-server Testing attached aiohttp websockets server
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: GustaafL <[email protected]>
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
.coveragerc
Outdated
| homeassistant/components/flexmeasures/const.py | ||
| homeassistant/components/flexmeasures/exception.py |
There was a problem hiding this comment.
I don't think you need to exclude these from coverage, they will be covered just by importing them?
|
|
||
| hass.data.setdefault(DOMAIN, {}) | ||
| hass.data[DOMAIN][entry.entry_id] = entry | ||
| hass.data[DOMAIN]["current_id"] = entry.entry_id |
There was a problem hiding this comment.
What's this for? It doesn't seem to be used?
| """Set up FlexMeasures from a config entry.""" | ||
|
|
||
| hass.data.setdefault(DOMAIN, {}) | ||
| hass.data[DOMAIN][entry.entry_id] = entry |
There was a problem hiding this comment.
The integration only allows a single config entry, we don't need to index by config entry id here. Also, this is stored, but doesn't seem to be used?
| hass.data[DOMAIN][entry.entry_id] = entry | ||
| hass.data[DOMAIN]["current_id"] = entry.entry_id | ||
|
|
||
| config_data = dict(entry.data) |
There was a problem hiding this comment.
This dict is created but never used, please remove it
| ) | ||
|
|
||
| # store config | ||
| hass.data[DOMAIN][FRBC_CONFIG] = { |
There was a problem hiding this comment.
Don't store an untyped dict, make a dataclass instead, then the type checker and your IDE know's what's happening if you later retrieve it like this:
frbc_data: FRBCData = hass.data[DOMAIN]| raise CannotConnect(exception) from exception | ||
| try: | ||
| await client.get_access_token() | ||
| except Exception as exception: |
| except Exception as exception: | ||
| raise InvalidAuth(exception) from exception | ||
|
|
||
| # Return info that you want to store in the config entry. |
There was a problem hiding this comment.
| # Return info that you want to store in the config entry. |
| for field in ("url", "email", "password"): | ||
| if field in str(exception): | ||
| errors[field] = str(exception) |
There was a problem hiding this comment.
Instead of this string matching, raise a subclass of ValueError in FlexMeasuresClient to indicate what failed to validate.
| return self.async_create_entry(title=info["title"], data=user_input) | ||
|
|
||
| # Show form again, showing captured errors | ||
| # still do invalid_auth validation error is not yet shown properly |
There was a problem hiding this comment.
What does this comment mean?
| return OptionsFlowHandler(config_entry) | ||
|
|
||
|
|
||
| class OptionsFlowHandler(config_entries.OptionsFlow): |
There was a problem hiding this comment.
Please look into using SchemaOptionsFlowHandler it helps you inject the current settings in an options flow etc
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
We are still working on it 😄 |
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @GustaafL,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
-
990ed02e59f56846d7c712f934a30ca60f10fb7c- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
599f9c5a37bc7e8028bfd3ba3e9717c1fdfa351e- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
b98565ee823bfe5799cd1e7bea5b5ad895a1f786- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
966f084ca9f93b73b908e465fa417a1b543a5f48- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
829e2e4a3e087c4f8c60ceed8aab28be6703ac38- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
861cefbd3bc0889e5b77c1c26cfd7feada4029e1- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
7d5ff4b3a66595fab7d34d08a50e5aeccbc7ba58- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
7a271f8e75abd1545c7251eb88748b143dc5ef6b- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
efe1f3db5a78869212774384f0c4dff66e4644f5- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
e8ab1a5fd01fbf920fead7d6603f16102928eafd- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
413d72f4870035f9499bb6a74622faa323a543bb- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
f46767cd88934fc9250dd3446f398bfc57ded185- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
31c0478f293aabab237a1b9d345cc238457a1715- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
62d44a118780384deb2ac5907c29899abf0bc834- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
6b2663bc9210a66eea5d5c74d97bcb4c5f7b8cf3- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
ba75c35d29cf25700669d494adf72e86cc2603fa- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
94ef02a439737e7fd5cb571922612e7bdb8ca7fa- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
2e2e84a6f3898698f087c866aa3430e415a449a8- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
a4fbe811686bf761e828edbf64dedec63d504809- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
512c7df530d4933f90c328d81d09f5733e2a7783- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
a67b49e34208f8bd7a9d171d878e2e982a0d7bd5- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
20a35b046bafe2e1ce9823d9e9215885e1ce6810- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
e7101c1066926b3da1a08c578a4567dea0c5c87e- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
34198d314c5750a8c545234375076f33fe346e83- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
0234b0301391e9dc0f955df46698b47f9fe47f47- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
81ed50a29d91d1ecd71c489f258095868d2fd4ce- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
30ec2044247e56aff10994d90b8929b423284e29- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
243a89757b309dbf67ebbc1486d08d9ed833da82- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
59e9c6c5e1dca46513101088e55753e00c73ced9- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
b552bbe1e811f3c05c66f2ee5b6b454484d83e08- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
c0dfa19965813f53e082745c9ce31fe3cf16002c- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
c5edcf87c7a1a20bf4b95b3fca4bd16a5505cf72- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
be38963ce7d4d5f28ff2e6f46277823e0d26c1e5- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
60c5309a7866e2914ca9d1aaa6752f00f093b428- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
7ab3e79575a1fe46db3112f136d9726d2ed6dc5c- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
2c442727a740a34b90c0daf9aa1aad3be08ac675- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
4f0b9eb84955fab5966ef895c9f6e89fdcb79987- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
2cba652a410ac14f9fafacc9032e75df432ba14c- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <[email protected]>"[email protected]" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: