Clean up location manager after making updates suspend

[dshokouhi]

Summary

Noticed that we had a few places to clean up and remove overlapping suspend calls

also added in a flush location call to only be called when we need to restart location services to clear out the queue, its also recommended we call it as we use setMaxWaitTime() so this felt like the most appropriate place to call it.

geofences are also limited to 100 per app so adding in 2 condition checks there. Probably needs a docs update for this one and combined with high accuracy expanded mode will be fun to write 🙃

https://developer.android.com/develop/sensors-and-location/location/geofencing

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#1141

Any other notes

Tested these changes overnight to ensure it all still works as expected

[jpelgrom]

By removing launch in a lot of places the code now waits/runs in sequence instead of doing this async. I feel like launch was done on purpose in a couple of places, especially for multiserver setups where we want to send to all and don't want to wait for server A to timeout before trying server B. Was this change intentional on your end?

[dshokouhi]

By removing launch in a lot of places the code now waits/runs in sequence instead of doing this async. I feel like launch was done on purpose in a couple of places, especially for multiserver setups where we want to send to all and don't want to wait for server A to timeout before trying server B. Was this change intentional on your end?

well i did not consider that was trying to remove overlapping coroutines

think the latest commit should address this and leave just the setup pieces and notification commands as just suspend along with ensuring we dont hit the 100 geofence limit

[jpelgrom]

OK I think this is good now but am always a bit hesitant with location tracking changes.

Do you want to update the docs to mention the geofence limit? (And also specifically how it impacts with the extended zones for high accuracy)

[dshokouhi]

OK I think this is good now but am always a bit hesitant with location tracking changes.

agreed they are not fun to review nor make changes on

Do you want to update the docs to mention the geofence limit? (And also specifically how it impacts with the extended zones for high accuracy)

yes we should do that, let me write something up when i get a free moment and link it here

[jpelgrom]

Moving initial setup to not run async looks good to me, but should probably get one beta cycle before being pushed