Log action for external bus improv/scan command (#4942)

home-assistant · Dec 28, 2024 · 2936bfd · 2936bfd
1 parent 622a0b5
commit 2936bfd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt b/app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt
@@ -1677,8 +1677,14 @@ class WebViewActivity : BaseActivity(), io.homeassistant.companion.android.webvi
     }
 
     private fun scanForImprov() {
-        if (!packageManager.hasSystemFeature(PackageManager.FEATURE_BLUETOOTH_LE)) return
-        if (!hasWindowFocus()) return
+        if (!packageManager.hasSystemFeature(PackageManager.FEATURE_BLUETOOTH_LE)) {
+            Log.d(TAG, "Improv scan request ignored because device doesn't have Bluetooth")
+            return
+        }
+        if (!hasWindowFocus()) {
+            Log.d(TAG, "Improv scan request ignored because webview doesn't have focus")
+            return
+        }
         lifecycleScope.launch {
             if (presenter.shouldShowImprovPermissions()) {
                 supportFragmentManager.setFragmentResultListener(ImprovPermissionDialog.RESULT_KEY, this@WebViewActivity) { _, bundle ->

diff --git a/app/src/main/java/io/homeassistant/companion/android/webview/WebViewPresenterImpl.kt b/app/src/main/java/io/homeassistant/companion/android/webview/WebViewPresenterImpl.kt
@@ -490,7 +490,12 @@ class WebViewPresenterImpl @Inject constructor(
     }
 
     override fun startScanningForImprov(): Boolean {
-        if (!improvRepository.hasPermission(view as Context)) return false
+        if (!improvRepository.hasPermission(view as Context)) {
+            Log.d(TAG, "Improv scan request ignored because app doesn't have permission")
+            return false
+        } else {
+            Log.d(TAG, "Improv scan starting")
+        }
         improvJobStarted = System.currentTimeMillis()
         improvJob = mainScope.launch {
             withContext(Dispatchers.IO) {
@@ -517,6 +522,7 @@ class WebViewPresenterImpl @Inject constructor(
 
     override fun stopScanningForImprov(force: Boolean) {
         if (improvJob?.isActive == true && (force || System.currentTimeMillis() - improvJobStarted > 1000)) {
+            Log.d(TAG, "Improv scan stopping")
             improvRepository.stopScanning()
             improvJob?.cancel()
         }