Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud backup support #33
Cloud backup support #33
Changes from 3 commits
d45b3d8
8ec3d06
3ba34bc
182b0aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it matters, but if want to keep the context manager we could separate the cases where we can use the context manager from the cases we don't:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy tells me MultiDict takes a single type parameter, the keys are always
str
Maybe just type this as aiohttp's
Query
if aiohasupervisor does not modify it?https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession.request
https://github.com/aio-libs/aiohttp/blob/dbd77ad6e46a0f89268758cdc06c20afeaf13e96/aiohttp/client.py#L171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems
Query
would need a newer aiohttp version, it came in with this PR in 3.11.0 I think (currently pyproject.toml specifies 3.3.0 as minimum).Let's go with the fixed
MultiDict
typing for now.