Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for None in select function for PyComponent #7837

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

etihwo
Copy link
Contributor

@etihwo etihwo commented Apr 5, 2025

Call the _create__view function when _view__ is None, to avoid the error 'NoneType' object has no attribute 'select' Fix #7835

Call the `_create__view` function when ```_view__``` is None, to avoid the error 'NoneType' object has no attribute 'select'
Fix holoviz#7835
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (60d506e) to head (c311d05).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/custom.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7837      +/-   ##
==========================================
- Coverage   87.07%   86.65%   -0.43%     
==========================================
  Files         346      346              
  Lines       52941    52943       +2     
==========================================
- Hits        46100    45876     -224     
- Misses       6841     7067     +226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit 79217f4 into holoviz:main Apr 8, 2025
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when attempting to add PyComponent to FastListTemplate main
2 participants