-
Notifications
You must be signed in to change notification settings - Fork 5
Component creation transparency #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sourabhpoddar404
wants to merge
7
commits into
hobbit-project:pg-merge
Choose a base branch
from
melissadas:Component_creation_transparency
base: pg-merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7d392de
Implementation of Direct Container Creator
sourabhpoddar404 82bec47
Changes to BenchmarkControllerTest
sourabhpoddar404 90873d2
Added test case for new implementation
sourabhpoddar404 e14cc95
Changes for the component creation based on feedback
altafhusen-mr a57e2e1
Feedback changes
sourabhpoddar404 8a26f76
Added Javadocs for the components.
melissadas 3ac067f
Merge branch 'pg-merge' into Component_creation_transparency
MichaelRoeder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/main/java/org/hobbit/core/components/AbstractPlatformController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package org.hobbit.core.components; | ||
|
||
import com.rabbitmq.client.AMQP; | ||
|
||
public abstract class AbstractPlatformController extends AbstractCommandReceivingComponent{ | ||
|
||
public AbstractPlatformController() { | ||
super(); | ||
} | ||
|
||
public AbstractPlatformController(boolean execCommandsInParallel) { | ||
super(execCommandsInParallel); | ||
} | ||
|
||
public abstract void createComponent(byte command, byte[] data, String sessionId, AMQP.BasicProperties props); | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
src/main/java/org/hobbit/core/containerservice/ContainerCreation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package org.hobbit.core.containerservice; | ||
|
||
import java.util.Set; | ||
import org.hobbit.core.components.AbstractPlatformController; | ||
|
||
/** | ||
* This interface provides methods that provides functionalities | ||
* to create {@link DirectContainerCreator} or {@link RabbitMQContainerCreator} | ||
* | ||
* @author Altafhusen Makandar | ||
* @author Sourabh Poddar | ||
* @author Yamini Punetha | ||
* @author Melissa Das | ||
* | ||
*/ | ||
public interface ContainerCreation { | ||
|
||
/** | ||
* Creates the given number of data generators using the given image name | ||
* and environment variables. | ||
* | ||
* @param dataGeneratorImageName | ||
* name of the data generator Docker image | ||
* @param numberOfDataGenerators | ||
* number of generators that should be created | ||
* @param envVariables | ||
* environment variables for the data generators | ||
*/ | ||
Set<String> createDataGenerators(String dataGeneratorImageName, int numberOfDataGenerators, | ||
String[] envVariables, AbstractPlatformController dummyComponent); | ||
|
||
/** | ||
* Creates the given number of task generators using the given image name | ||
* and environment variables. | ||
* | ||
* @param taskGeneratorImageName | ||
* name of the task generator Docker image | ||
* @param numberOfTaskGenerators | ||
* number of generators that should be created | ||
* @param envVariables | ||
* environment variables for the task generators | ||
*/ | ||
Set<String> createTaskGenerators(String taskGeneratorImageName, int numberOfTaskGenerators, | ||
String[] envVariables, AbstractPlatformController dummyComponent); | ||
|
||
/** | ||
* Creates the evaluate storage using the given image name and environment | ||
* variables. | ||
* | ||
* @param evalStorageImageName | ||
* name of the evaluation storage image | ||
* @param envVariables | ||
* environment variables that should be given to the component | ||
*/ | ||
String createEvaluationStorage(String evalStorageImageName, String[] envVariables, | ||
AbstractPlatformController dummyComponent); | ||
|
||
} |
34 changes: 34 additions & 0 deletions
34
src/main/java/org/hobbit/core/containerservice/ContainerCreationFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package org.hobbit.core.containerservice; | ||
|
||
import org.hobbit.core.Constants; | ||
import org.hobbit.core.components.AbstractBenchmarkController; | ||
|
||
/** | ||
* This class provides functionality to obtain an instance of {@link ContainerCreation} | ||
* | ||
* @author Altafhusen Makandar | ||
* @author Sourabh Poddar | ||
* @author Yamini Punetha | ||
* @author Melissa Das | ||
* | ||
*/ | ||
public class ContainerCreationFactory { | ||
|
||
/** | ||
* This static method returns the instance of {@link RabbitMQContainerCreator} or {@link DirectContainerCreator} | ||
* based on the value of the environment variable {@link Constants#RABBIT_CONTAINER_SERVICE} | ||
* | ||
* @param isRabbitContainerService | ||
* the environment variable that decides which instance of {@link ContainerCreation} will be returned. | ||
* @param abstractBenchmarkController | ||
* instance of {@link AbstractBenchmarkController} | ||
* @return an instance of {@link RabbitMQContainerCreator} or {@link DirectContainerCreator} | ||
*/ | ||
public static ContainerCreation getContainerCreationObject(String isRabbitContainerService, AbstractBenchmarkController abstractBenchmarkController) { | ||
if(isRabbitContainerService.equals("true")) { | ||
return new RabbitMQContainerCreator(abstractBenchmarkController); | ||
} | ||
return new DirectContainerCreator(abstractBenchmarkController); | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add javadoc comments to all methods of this interface.