Bump crossbeam-utils to 0.7

[alex]

No description provided.

[hniksic]

@alex Have you actually tried building with crossbeam 0.7? It appears to break the build.

[alex]

I did not, since it was Windows only, and I don't have a Windows machine. I did my best to check by hand, but it looks like I missed something. Sorry about that :-(

…

On Sat, Dec 7, 2019 at 7:48 AM Hrvoje Nikšić ***@***.***> wrote: @alex <https://github.com/alex> Have you actually tried building with crossbeam 0.7? It appears to break the build <https://travis-ci.org/hniksic/rust-subprocess/jobs/620837860?utm_medium=notification&utm_source=email> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31?email_source=notifications&email_token=AAAAGBFFE4OUU2VUWY56PA3QXOLTBA5CNFSM4JVNANR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGGGLQ#issuecomment-562848558>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBGMVUECDZU2XGEPDX3QXOLTBANCNFSM4JVNANRQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[hniksic]

I did not, since it was Windows only, and I don't have a Windows machine.

Good that we have Windows CI. :) Just out of curiosity, why did you submit the PR if you're not using the functionality?

Regarding the error itself, it seems that crossbeam changed its API incompatibly. Judging by the compilation output, it should be straightforward to fix; would you like to try?

[alex]

I try to keep my cargo.lock from bloating with too many versions of the same package, even if they're not actually being used in my builds.

[alex]

It looks like simply unwrap()ing the Result would match the behavior of 0.5 (https://docs.rs/crossbeam-utils/0.5.0/crossbeam_utils/thread/fn.scope.html#panics). Would you like that implementation, or to attempt to turn the Err into an IoResult::Err?

[hniksic]

@alex Sorry, I apparently missed this message!

In the meantime I've made the change to unwrap() the result (so the answer to your question would have been "yes"), and also fixed the closures to accept the unused scope parameter passed by the new version.

[hniksic]

This PR is now included in the release, possibly relevant to @sanxiyn.

[hniksic]

Also, crossbeam-utils is no longer a dependency.