Revert versioning changes#349
Conversation
This reverts commit 5aef00d.
This reverts commit bffb372.
This reverts commit 0f41be1.
This reverts commit 4057f32.
This reverts commit 1bc4d32.
This reverts commit 4174d95.
This reverts commit f59421d.
This reverts commit a56de02.
This reverts commit d730e64.
This reverts commit 5cf7b01.
This reverts commit a0fcc3c.
This reverts commit 9bc68e2.
This reverts commit 0b7b383.
|
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/connectors/TraderMovementConnectorV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/connectors/TraderMovementConnector.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/controllers/DraftExciseMovementControllerV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/controllers/DraftExciseMovementController.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/factories/IEMessageFactoryV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/factories/IEMessageFactory.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/auditing/AuditEventFactoryV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/auditing/AuditEventFactory.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/messages/v2/MessageTypeFormats/GeneratedJsonWritersV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/messages/MessageTypeFormats/GeneratedJsonWriters.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/validation/MessageValidationV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/validation/MessageValidation.scala"
| configuration: Configuration | ||
| )(implicit ec: ExecutionContext) | ||
| extends PlayMongoRepository[Movement]( | ||
| collectionName = appConfig.movementCollectionName, |
There was a problem hiding this comment.
Going to call this one out specifically because it's probably the most important change in the PR 😁
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/AuditServiceV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/AuditService.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/MessageServiceV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/MessageService.scala"
There was a problem hiding this comment.
git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/utils/NrsEventIdMapperV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/utils/NrsEventIdMapper.scala"
This PR reverts all changes since #328 except for #330 and #331.
I manually reapplied #346 and the switch to the
movements_v2collection.See comments below for commands to show the actual diff between the versioned classes and the unsuffixed classes in this PR.