Skip to content

Revert versioning changes#349

Open
DavidGregory084 wants to merge 17 commits into
hmrc:mainfrom
DavidGregory084:revert-versioning-changes
Open

Revert versioning changes#349
DavidGregory084 wants to merge 17 commits into
hmrc:mainfrom
DavidGregory084:revert-versioning-changes

Conversation

@DavidGregory084
Copy link
Copy Markdown
Contributor

@DavidGregory084 DavidGregory084 commented Feb 16, 2026

This PR reverts all changes since #328 except for #330 and #331.

I manually reapplied #346 and the switch to the movements_v2 collection.

See comments below for commands to show the actual diff between the versioned classes and the unsuffixed classes in this PR.

DavidGregory084 and others added 17 commits February 16, 2026 16:30
This reverts commit 0b7b383.
This reverts commit ef337dc, reversing
changes made to 1ec1cc9.
@platops-pr-bot
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor Author

@DavidGregory084 DavidGregory084 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/connectors/TraderMovementConnectorV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/connectors/TraderMovementConnector.scala"

Copy link
Copy Markdown
Contributor Author

@DavidGregory084 DavidGregory084 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/controllers/DraftExciseMovementControllerV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/controllers/DraftExciseMovementController.scala"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/factories/IEMessageFactoryV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/factories/IEMessageFactory.scala"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/auditing/AuditEventFactoryV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/auditing/AuditEventFactory.scala"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/messages/v2/MessageTypeFormats/GeneratedJsonWritersV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/messages/MessageTypeFormats/GeneratedJsonWriters.scala"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/validation/MessageValidationV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/models/validation/MessageValidation.scala"

configuration: Configuration
)(implicit ec: ExecutionContext)
extends PlayMongoRepository[Movement](
collectionName = appConfig.movementCollectionName,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to call this one out specifically because it's probably the most important change in the PR 😁

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/AuditServiceV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/AuditService.scala"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/MessageServiceV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/services/MessageService.scala"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff "4d01b58efd0f7b5911be9fe78155b46b7c8f11ed:app/uk/gov/hmrc/excisemovementcontrolsystemapi/utils/NrsEventIdMapperV2.scala" "HEAD:app/uk/gov/hmrc/excisemovementcontrolsystemapi/utils/NrsEventIdMapper.scala"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants