-
Notifications
You must be signed in to change notification settings - Fork 1
DTR-4656: CIS Amend Flow Business Function F2 - Create amended monthly return #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
de1752e
DTR-4536: Initial scaffold
samraducan 5148771
DTR-4536: Add page content and unit tests
samraducan dc39eeb
DTR-4536: Move files inside the amend folder
samraducan c8fd17c
Merge branch 'main' into DTR-4536
samraducan c873b3d
DTR-4536: Address PR comments
samraducan 3715ac0
Merge branch 'main' into DTR-4536
samraducan 3fcaa1c
DTR-4536: Run sbt formatAll
samraducan 81be5cd
Merge branch 'main' into DTR-4536
samraducan bcd0a58
DTR-4536: Add boolean flag for confirm and continue button and update…
samraducan 8aa0bf6
Merge branch 'main' into DTR-4536
samraducan 0c033c8
Merge branch 'main' into DTR-4536
samraducan bf8b90e
[DTR-4656] CIS Amend Flow Business Function F2 - Create amended month…
yanshengzhangHMRC efa6a8d
[DTR-4656] add tests
yanshengzhangHMRC e9588be
Merge branch 'main' into DTR-4656
yanshengzhangHMRC 37a8ef7
[DTR-4656] clean up
yanshengzhangHMRC df53979
[DTR-4656] resolve PR comments
yanshengzhangHMRC 06bb5d8
Merge branch 'main' into DTR-4656
yanshengzhangHMRC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Copyright 2026 HM Revenue & Customs | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package models.amend | ||
|
|
||
| import play.api.libs.json.{Json, OFormat} | ||
|
|
||
| case class AmendmentDetails( | ||
| instanceId: String, | ||
| taxYear: Int, | ||
| taxMonth: Int | ||
| ) | ||
|
|
||
| object AmendmentDetails { | ||
| given format: OFormat[AmendmentDetails] = Json.format[AmendmentDetails] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright 2026 HM Revenue & Customs | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package models.amend | ||
|
|
||
| import play.api.libs.json.{Json, OFormat} | ||
|
|
||
| case class CreateAmendedMonthlyReturnRequest( | ||
| instanceId: String, | ||
| taxYear: Int, | ||
| taxMonth: Int, | ||
| version: Int | ||
| ) | ||
|
|
||
| object CreateAmendedMonthlyReturnRequest { | ||
| given format: OFormat[CreateAmendedMonthlyReturnRequest] = Json.format[CreateAmendedMonthlyReturnRequest] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Copyright 2026 HM Revenue & Customs | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package pages.amend | ||
|
|
||
| import models.amend.AmendmentDetails | ||
| import pages.QuestionPage | ||
| import play.api.libs.json.JsPath | ||
|
|
||
| case object AmendmentDetailsPage extends QuestionPage[AmendmentDetails] { | ||
|
|
||
| override def path: JsPath = JsPath \ toString | ||
|
|
||
| override def toString: String = "amendmentDetails" | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright 2026 HM Revenue & Customs | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package services | ||
|
|
||
| import connectors.ConstructionIndustrySchemeConnector | ||
| import models.amend.CreateAmendedMonthlyReturnRequest | ||
| import uk.gov.hmrc.http.HeaderCarrier | ||
|
|
||
| import javax.inject.{Inject, Singleton} | ||
| import scala.concurrent.Future | ||
|
|
||
| @Singleton | ||
| class AmendMonthlyReturnService @Inject() (cisConnector: ConstructionIndustrySchemeConnector) { | ||
|
|
||
| def createAmendedMonthlyReturn(request: CreateAmendedMonthlyReturnRequest)(implicit hc: HeaderCarrier): Future[Unit] = | ||
| cisConnector.createAmendedMonthlyReturn(request) | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.