[APB-11045][APB-APB-11015] Success and FailedNonFixable emails by gitwojciech · Pull Request #63 · hmrc/agent-registration-risking

gitwojciech · 2026-04-29T14:35:14Z

No description provided.

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

# Conflicts: # app/uk/gov/hmrc/agentregistration/shared/risking/IndividualRiskingResponse.scala # app/uk/gov/hmrc/agentregistrationrisking/model/IndividualForRisking.scala # test/uk/gov/hmrc/agentregistrationrisking/testsupport/testdata/TdApplicationForRisking.scala # test/uk/gov/hmrc/agentregistrationrisking/testsupport/testdata/TdIndividualForRisking.scala

…nts2

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/controllers/SubmitForRiskingController.scala # app/uk/gov/hmrc/agentregistrationrisking/testOnly/controllers/controllers/TestRiskingController.scala # test/uk/gov/hmrc/agentregistrationrisking/testsupport/testdata/TdSdesProxy.scala

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

…der improvement

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/controllers/SdesNotificationController.scala # app/uk/gov/hmrc/agentregistrationrisking/services/ApplicationStatusService.scala

…merge with 11100WIP testing failing

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/testOnly/controllers/controllers/TestRiskingController.scala

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

# Conflicts: # test/uk/gov/hmrc/agentregistrationrisking/controllers/SdesNotificationControllerSpec.scala # test/uk/gov/hmrc/agentregistrationrisking/repository/ApplicationForRiskingRepoSpec.scala # test/uk/gov/hmrc/agentregistrationrisking/scheduler/RiskingSchedulerInitializerSpec.scala # test/uk/gov/hmrc/agentregistrationrisking/services/SubscriptionServiceSpec.scala # test/uk/gov/hmrc/agentregistrationrisking/testsupport/testdata/TdAll.scala

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/controllers/SdesNotificationController.scala # app/uk/gov/hmrc/agentregistrationrisking/repository/ApplicationForRiskingRepo.scala # app/uk/gov/hmrc/agentregistrationrisking/services/ApplicationStatusService.scala # app/uk/gov/hmrc/agentregistrationrisking/services/SubscriptionService.scala

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/controllers/SdesNotificationController.scala

platops-pr-bot · 2026-05-08T11:44:23Z

Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

paweldigital · 2026-05-08T11:52:08Z

      )
    ).toFuture()

+//  def findReadyForSubscription(): Future[Seq[ApplicationForRisking]] = collection


I was wondering what the purpose of this commented-out code is.

paweldigital · 2026-05-08T12:03:27Z

+ * limitations under the License.
+ */
+
+///*


I was wondering if there’s any value in keeping these commented-out files, as they don’t seem to serve a purpose, or am I missing something? I have a small suggestion to consider removing them, and perhaps we could also avoid including similar unused or commented-out files in the future, if that’s not an issue of course.

paweldigital · 2026-05-08T12:07:15Z

+)(using ExecutionContext)
+extends RequestAwareLogging:
+
+  def sendEmail(emailInformation: EmailInformation)(using RequestHeader): Future[Unit] = emailConnector.sendEmail(emailInformation)


I was wondering if there’s any particular reason this method is exposed in the service. It seems to be used only internally, so I was thinking it might be worth considering whether it could be made private or inlined, especially since it relies on an underlying private connector to send emails. From an encapsulation perspective, it might help improve the structure of the code if we clean this up a bit, if that makes sense.

paweldigital · 2026-05-08T12:14:58Z

+import play.api.libs.json.Json
+import play.api.libs.json.OFormat
+
+final case class EmailInformation(


Could we consider renaming EmailInformation to SendEmailRequest to better reflect that it represents the actual HTTP request used when calling the email microservice? It seems we already follow this naming convention in other connectors, so it might be good to stay consistent with that.

paweldigital · 2026-05-08T12:18:34Z

+import play.api.libs.json.OFormat
+
+final case class EmailInformation(
+  to: Seq[String],


I was wondering if it might be worth using a dedicated type for the email address, such as EmailAddress, instead of a plain String. It already seems to handle the necessary JSON serialization, and it could make the code more type-safe overall.

to: Seq[String] feels a bit unclear compared to to: Seq[EmailAddress], does it?

paweldigital · 2026-05-08T12:20:04Z

+
+final case class EmailInformation(
+  to: Seq[String],
+  templateId: String,


Could we consider using a dedicated type for this as well? Since we only have a small set of email template values, it might make sense to model them as an enum. That way, we could reduce the risk of passing incompatible or unsupported values.

paweldigital · 2026-05-08T12:21:09Z

+  eventUrl: Option[String] = None,
+  onSendUrl: Option[String] = None


I was wondering if those fields are still needed, as they don’t seem to be used anywhere. Maybe it would make sense to remove them to avoid maintaining code that isn’t actually in use?

paweldigital · 2026-05-08T13:48:58Z

+        Filters.eq("isSubscribed", true),
+        Filters.eq("isEmailSent", false)


Could we consider using a FieldNames object to define these fields? It makes them easier to manage and help avoid typos in queries, especially since this has already happened in the project before.

paweldigital and others added 19 commits April 16, 2026 16:06

[APB-11100] model

7c02966

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] model

4477295

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[WG][APB-11100] Do actions per Pav description

232a634

[WG][APB-11100] Do actions per Pav description, merge main

d9d3647

[WG][APB-11100] Do actions per Pav description, RiskingFile repo

f35b4f4

[WG][APB-11100] lastUpdatedAt - update when risking responce

853c591

[WG][APB-11100] lastUpdatedAt - update when risking responce 2

c016314

[WG][APB-11100] lastUpdatedAt - update when risking responce PR comme…

86b63ef

…nts2

PP WG [APB-11100] alignement

d9be6f4

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[WG][APB-11100] make code compile plus tests

c5f5830

PP WG [APB-11100] readme

d169df3

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

PP WG [APB-11100] comments

fe20e1a

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

PP WG [APB-11100] fixes after merge

6c1d1a3

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

PP WG [APB-11100] fixes in tests

7dd4bc5

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[WG][APB-11045] Risking outcomes - emails - success

6059914

[APB-11100] fixes after sync from FE

e646367

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[WG][APB-11015] Risking outcomes - emails - FailedNonFixable

d4099ae

gitwojciech marked this pull request as draft April 29, 2026 14:35

paweldigital and others added 10 commits April 29, 2026 16:24

[APB-11100] refactored production cod

16b4cf0

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[WG][APB-11015] Risking outcomes - emails - FailedNonFixable, SoleTra…

b05ea41

…der improvement

Merge branch 'APB-11100_2' into APB-11045

08ad1f1

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/controllers/SdesNotificationController.scala # app/uk/gov/hmrc/agentregistrationrisking/services/ApplicationStatusService.scala

[DC-8799][APB-11045][APB-11015] agent registartion emails - success, …

05e90e0

…merge with 11100WIP testing failing

[APB-11100] tests commented out, wip

04d21ea

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] ProcessInSequenceSpec

5f2e1de

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] Test Data for Risking POC

33b9ad9

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

Merge branch 'main' into APB-11100

92720e9

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/testOnly/controllers/controllers/TestRiskingController.scala

[APB-11100] Test Data fixes

cb1cf32

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

gitwojciech and others added 12 commits May 5, 2026 11:15

[APB-11045] agent registartion emails - remove testing

cb938ac

[APB-11100] More TD Fixes and compiling first test

a0eb410

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] first working test

ff2a7e7

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] small cleanup

246c12b

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] getRiskingProgressForApplicant test

c3f7ba1

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] risking results for applicant

c9b5789

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

[APB-11100] sync

aa08cd3

Signed-off-by: pav <173694350+paweldigital@users.noreply.github.com>

Merge branch 'APB-11100_2' into APB-11045

45cad5a

[APB-11045] agent registartion emails - after merge fix

357f824

[APB-11045] agent registartion emails - after merge fix2

8023e25

Merge branch 'main' into APB-11045

c28f356

gitwojciech marked this pull request as ready for review May 7, 2026 13:29

gitwojciech added 2 commits May 8, 2026 12:27

Merge branch 'main' into APB-11045

aa8850b

# Conflicts: # app/uk/gov/hmrc/agentregistrationrisking/controllers/SdesNotificationController.scala

[APB-11045] agent registartion emails - another merge fixes

63e98e9

paweldigital reviewed May 8, 2026

View reviewed changes

[APB-11045] agent registartion emails - PR comments

6cd0888

paweldigital reviewed May 8, 2026

View reviewed changes

gitwojciech added 3 commits May 8, 2026 15:22

[APB-11045] agent registartion emails - PR comments 2

f4839cb

[APB-11045] agent registartion emails - better emails for indyviduals

d2dcab6

[APB-11045] agent registartion emails - more filters

cb08a60

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APB-11045][APB-APB-11015] Success and FailedNonFixable emails#63

[APB-11045][APB-APB-11015] Success and FailedNonFixable emails#63
gitwojciech wants to merge 47 commits intomainfrom
APB-11045

gitwojciech commented Apr 29, 2026

Uh oh!

platops-pr-bot commented May 8, 2026

Uh oh!

paweldigital May 8, 2026 •

edited

Loading

Uh oh!

paweldigital May 8, 2026

Uh oh!

paweldigital May 8, 2026

Uh oh!

paweldigital May 8, 2026

Uh oh!

paweldigital May 8, 2026

Uh oh!

paweldigital May 8, 2026

Uh oh!

paweldigital May 8, 2026

Uh oh!

paweldigital May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		eventUrl: Option[String] = None,
		onSendUrl: Option[String] = None

		Filters.eq("isSubscribed", true),
		Filters.eq("isEmailSent", false)

Conversation

gitwojciech commented Apr 29, 2026

Uh oh!

platops-pr-bot commented May 8, 2026

Uh oh!

paweldigital May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

paweldigital May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paweldigital May 8, 2026 •

edited

Loading