Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google Tag Manager support #1266

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added Google Tag Manager support #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3de8693
added Google Tag Manager support
HYadavHMCTS Feb 8, 2024
d484afc
update to common lib ver 2.0.15
HYadavHMCTS Feb 8, 2024
e7dd0eb
updated yarn.lock
HYadavHMCTS Feb 8, 2024
f34bbf2
updated common lib ref to 2.0.16
HYadavHMCTS Feb 8, 2024
7959136
updated yarn audit known issues file
HYadavHMCTS Feb 8, 2024
47a6ef4
Update yarn-audit-known-issues
HYadavHMCTS Feb 12, 2024
b672916
Update app.component.spec.ts
HYadavHMCTS Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified api/.yarn/install-state.gz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"@hmcts/media-viewer": "2.10.1-RC.1",
"@hmcts/nodejs-healthcheck": "1.7.0",
"@hmcts/properties-volume": "0.0.13",
"@hmcts/rpx-xui-common-lib": "2.0.10",
"@hmcts/rpx-xui-common-lib": "2.0.16",
"@hmcts/rpx-xui-node-lib": "2.27.1",
"@ng-idle/core": "^10.0.0",
"@ng-idle/keepalive": "^10.0.0",
Expand Down
1 change: 1 addition & 0 deletions src/app/containers/app/app.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const featureMock: FeatureToggleService = {
initialize: () => {},
isEnabled: () => of(true),
getValue: () => of(),
getValueSync: () => null,
getValueOnce: () => of()
};

Expand Down
12 changes: 12 additions & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<!doctype html>
<html lang="en">
<head>
<!-- Google Tag Manager -->
<script>
(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src='https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);})(window,document,'script','dataLayer','GTM-5QD5LRZX');
</script>
<!-- End Google Tag Manager -->
<meta charset="utf-8" http-equiv="encoding">
<meta content="text/html;charset=utf-8" http-equiv="Content-Type">
<base href="/">
Expand All @@ -9,6 +14,13 @@
<link rel="icon" type="image/x-icon" href="favicon.ico">
</head>
<body class="govuk-template__body js-enabled">
<!-- Google Tag Manager (noscript) -->
<noscript>
<iframe src="https://www.googletagmanager.com/ns.html?id=GTM-5QD5LRZX"
height="0" width="0" style="display:none;visibility:hidden">
</iframe>
</noscript>
<!-- End Google Tag Manager (noscript) -->
<app-root></app-root>
</body>
</html>
2 changes: 1 addition & 1 deletion yarn-audit-known-issues
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2550,16 +2550,16 @@ __metadata:
languageName: node
linkType: hard

"@hmcts/rpx-xui-common-lib@npm:2.0.10":
version: 2.0.10
resolution: "@hmcts/rpx-xui-common-lib@npm:2.0.10"
"@hmcts/rpx-xui-common-lib@npm:2.0.16":
version: 2.0.16
resolution: "@hmcts/rpx-xui-common-lib@npm:2.0.16"
dependencies:
tslib: ^2.0.0
peerDependencies:
launchdarkly-js-client-sdk: ^2.15.2
ngx-pagination: ^3.2.1
rpx-xui-translation: ^0.1.1
checksum: 67279767d814cb9916b0d5af16fa55d96792d5b69ed1096c146889533da39e7a5c7f59dfad0a1c35f062e06c8ab4aeecf1c9117311dae2031c5425a6a52ce68d
checksum: e53f9947cc67802ad536de011e1e7f66c3fae9e9f77b33d3f0337ea44d9d22a367ce421326a70985a9a90cb72497fab8190dad883d192290589230d47e787e03
languageName: node
linkType: hard

Expand Down Expand Up @@ -18678,7 +18678,7 @@ __metadata:
"@hmcts/media-viewer": 2.10.1-RC.1
"@hmcts/nodejs-healthcheck": 1.7.0
"@hmcts/properties-volume": 0.0.13
"@hmcts/rpx-xui-common-lib": 2.0.10
"@hmcts/rpx-xui-common-lib": 2.0.16
"@hmcts/rpx-xui-node-lib": 2.27.1
"@ng-idle/core": ^10.0.0
"@ng-idle/keepalive": ^10.0.0
Expand Down