Fix flakey tests #2564
Open
Fix flakey tests #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text This test relies on tight timings which causes it to regularly fail. The final request had a delay of 490ms which is close to the 500ms http timeout the test configures. The test scenario doesn't require a delay for the final request.
danlysiak
approved these changes
Apr 23, 2025
added 2 commits
April 24, 2025 20:21
Ensure we wait for indexing to finish before proceeding with tests.
The DocumentsOperationTest modifies the spring boot test context using field level reflection which was breaking other tests. @DirtiesContext ensures this modified context is not reused in subsequent tests.
banderous
changed the title
RebeccaBaker
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldRetryOnErrorWithIgnoreWarningFalseAndDefaultRetryContext This test relies on tight timings which causes it to regularly fail.
The final request had a delay of 490ms which is close to the 500ms http timeout the test configures. The test scenario doesn't require any delay for the final request which is expected to succeed so can be removed.