Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rum update #432

Merged
merged 1 commit into from
Jan 10, 2024
Merged

rum update #432

merged 1 commit into from
Jan 10, 2024

Conversation

nsdere
Copy link
Collaborator

@nsdere nsdere commented Jan 9, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #431

Test URLs:

@nsdere nsdere requested review from basecode and chicharr January 9, 2024 16:14
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 9, 2024

Page Scores Audits Google
/solutions/premium-security PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

chicharr
chicharr approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@chicharr chicharr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@nsdere you can set the test urls to .live instead of .page to avoid the long Speed Index

@nsdere nsdere merged commit 833985d into main Jan 10, 2024
1 of 3 checks passed
@nsdere nsdere deleted the 431-rum-update branch January 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basecode basecode basecode approved these changes

@chicharr chicharr chicharr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating RUM script in order to get the data in order
3 participants
@nsdere @basecode @chicharr