Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add experimentation #430

Merged
merged 23 commits into from
Jan 10, 2024
Merged

feat: add experimentation #430

merged 23 commits into from
Jan 10, 2024

Conversation

vtsaplin
Copy link
Collaborator

@vtsaplin vtsaplin commented Dec 20, 2023 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 20, 2023 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 20, 2023 •
edited
Loading

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 11:49 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 12:06 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 12:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 12:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 13:07 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 13:11 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 13:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 13:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 13:53 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 14:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 3, 2024 14:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 4, 2024 14:30 Inactive
@vtsaplin
Squashed 'solutions/plugins/experimentation/' changes from b033075..1…
2e2bc62 
…62896d

162896d Update README.md
06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (#10)

git-subtree-dir: solutions/plugins/experimentation
git-subtree-split: 162896dd4908cf5b5270477a9a367ccd649d4d7d
@vtsaplin
Merge commit '2e2bc6235c38414185a1eb217c5d45272fef9d9c' into experime…
72c1148 
…ntation
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation January 8, 2024 12:42 Inactive
@vtsaplin vtsaplin marked this pull request as ready for review January 8, 2024 13:28
@vtsaplin vtsaplin requested a review from chicharr January 10, 2024 10:40
basecode
basecode requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@basecode basecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing

README.md Outdated Show resolved Hide resolved
@vtsaplin vtsaplin requested a review from basecode January 10, 2024 13:40
@vtsaplin vtsaplin merged commit ab15990 into main Jan 10, 2024
2 of 3 checks passed
@vtsaplin vtsaplin deleted the experimentation branch January 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basecode basecode basecode approved these changes

@ramboz ramboz ramboz approved these changes

@andreibogdan andreibogdan Awaiting requested review from andreibogdan

@vradulescu-bd vradulescu-bd Awaiting requested review from vradulescu-bd

@chicharr chicharr Awaiting requested review from chicharr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtsaplin @basecode @ramboz