Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleWriterService > Cascade all exceptions that can be thrown during the task execution. #437

Merged
merged 1 commit into from
Dec 18, 2023
Merged

SingleWriterService > Cascade all exceptions that can be thrown during the task execution. #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/hivemq/persistence/InMemoryProducerQueues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public InMemoryProducerQueues(final int persistenceBucketCount, final int amount
} else {
successCallback.afterTask(result);
}
} catch (final Exception e) {
} catch (final Throwable e) {
if (resultFuture != null) {
resultFuture.setException(e);
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/hivemq/persistence/ProducerQueuesImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ public void execute(final @NotNull SplittableRandom random) {
.afterTask(result));
}
}
} catch (final Exception e) {
} catch (final Throwable e) {
if (taskWithFuture.getFuture() != null) {
taskWithFuture.getFuture().setException(e);
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/hivemq/persistence/SingleWriterService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ interface SuccessCallback<R> {
}

interface FailedCallback {
void afterTask(@NotNull Exception exception);
void afterTask(@NotNull Throwable exception);
}
}
Loading