chore: added configuring Nx for Jest/Jasmine #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtpultz
commented
Mar 10, 2022
•
mtpultz
commented
- Added configuring Nx section
- Small edits to Using TypeScript section
- Applied minor CSS to summary tags
* Added configuring Nx section * Small edits to Using TypeScript section * Applied minor CSS to <summary>
|
Similar files are |
|
Thanks a lot @mtpultz ! Just had some time now to review it I'm leaving a few comments on the changes themselves |
shairez
reviewed
Mar 21, 2022
| // For tsconfig.spec.json AND tsconfig.editor.json: | ||
| { | ||
| "compilerOptions": { | ||
| "types": [ |
There was a problem hiding this comment.
@mtpultz thanks!
There's a typo in the code - it should be "jasmine" no?
Plus - have you checked that this configuration works with an nx project that is generated with "jasmine + karma" instead of jest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.