i encountered this while trying to reproduce a different bug

hiimjasmine00 · Aug 11, 2024 · af29de3 · af29de3
1 parent 513d324
commit af29de3
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -4,7 +4,7 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_OSX_ARCHITECTURES "x86_64;arm64")
 set(CMAKE_CXX_VISIBILITY_PRESET hidden)
 
-project(FakeRate VERSION 1.3.5)
+project(FakeRate VERSION 1.3.6)
 
 add_library(${PROJECT_NAME} SHARED
     src/FakeRate.cpp

diff --git a/changelog.md b/changelog.md
@@ -1,4 +1,7 @@
 # Fake Rate Changelog
+## v1.3.6 (2024-08-10)
+- Fixed a bug where More Difficulties difficulties would not display ever
+
 ## v1.3.5 (2024-08-09)
 - Fixed a bug where the difficulty face would not display at all if a fake rate was set
 

diff --git a/mod.json b/mod.json
@@ -5,7 +5,7 @@
         "win": "2.206",
         "mac": "2.206"
     },
-    "version": "v1.3.5",
+    "version": "v1.3.6",
     "id": "hiimjustin000.fake_rate",
     "name": "Fake Rate",
     "developer": "hiimjustin000",

diff --git a/src/main.cpp b/src/main.cpp
@@ -215,7 +215,7 @@ class $modify(FRLevelInfoLayer, LevelInfoLayer) {
         auto stars = m_level->m_stars.value();
         if (remove && stars == 0 && (starsRequested == 4 || starsRequested == 7 || starsRequested == 9)) moreDifficultiesOverride = starsRequested;
         if (remove && stars == 4 || stars == 7 || stars == 9) moreDifficultiesOverride = stars;
-        if (moreDifficultiesOverride != 4 || moreDifficultiesOverride != 7 || moreDifficultiesOverride != 9 || gdo > 0 || dbo > 0) return;
+        if ((moreDifficultiesOverride != 4 && moreDifficultiesOverride != 7 && moreDifficultiesOverride != 9) || gdo > 0 || dbo > 0) return;
 
         auto legacy = Loader::get()->getLoadedMod("uproxide.more_difficulties")->getSettingValue<bool>("legacy-difficulties");
         if (!moreDifficultiesSprite) {
@@ -405,7 +405,7 @@ class $modify(FRLevelCell, LevelCell) {
 
         auto difficultySprite = static_cast<GJDifficultySprite*>(difficultyContainer->getChildByID("difficulty-sprite"));
         difficultySprite->setOpacity(255);
-        if (mdo != 4 || mdo != 7 || mdo != 9 || gdo > 0 || dbo > 0) return;
+        if ((mdo != 4 && mdo != 7 && mdo != 9) || gdo > 0 || dbo > 0) return;
         difficultySprite->setOpacity(0);
 
         auto legacy = Loader::get()->getLoadedMod("uproxide.more_difficulties")->getSettingValue<bool>("legacy-difficulties");