-
Notifications
You must be signed in to change notification settings - Fork 24
Added firstName and lastName #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| user.email = response.email; | ||
| user.token = response.token; | ||
| user.firstName = response.first_name; | ||
| user.lastName = response.lastName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be last_name, at least for v3.1 api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll fix it
|
Fixed! |
|
Could you please merge this pull request? It's is very useful for me |
|
If its very useful you can always add this manually to your project as I did. I improved your idea by adding a way to specify which fields you want to get from ie. fbApi. Take a look here, maybe it will help you. |
|
Yes, sure, but I didn't succeed in installing the package from github...
does not work |
|
That won't work. By manual install I mean download zip, unzip it and move to your project. I wanted to publish my mod as npm package but failed at some point. But I can assure you, manually copying it to your project will work. |
|
Yes, you are right, but I prefer to get the packages from the repository.
Thank you!
…On Tue, Nov 13, 2018 at 4:24 PM MikeDabrowski ***@***.***> wrote:
That won't work. By manual install I mean download zip, unzip it and move
to your project. I wanted to publish my mod as npm package but failed at
some point. But I can assure you, manually copying it to your project will
work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABr3CXa_K3aBKj-vKDTwCGrLLlrq3K1Iks5uuxxggaJpZM4WXgIx>
.
|
I found this module very useful, but in my current project I need to distinct first name and last name. This pull request contains the changes needed to get that data from the user profile