Fix DAA instruction #183
Merged
Fix DAA instruction #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I can confirm this fixes both failures in blargg's CPU instruction test ROM. |
|
@Meepster99 do you know if this impacts ares too, or if it was already fixed there? If not, can we have permission to merge this into ares too? I need to ask because higan is GPL but ares is ISC licensed, so we can't just assume you're happy. |
|
ares fails blargg's CPU instruction tests the same way higan did (I checked). |
|
im not sure if this is present in ares, but feel free to merge this there too |
LukeUsher
added a commit
to ares-emulator/ares
that referenced
this pull request
Aug 18, 2021
thanks Meepster99, ported from higan-emu/higan#183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original gameboy's instruction file, the old DAA instruction modified the A register and used the modified value for further checks.
Also, the carry flag was not set properly.