sfc: Really fix automatic joypad polling, for sure. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since they aren't hyperlinked in the OP, the bsnes commits mentioned are bsnes-emu/bsnes@39c37ec and bsnes-emu/bsnes@4f7a269. |
In commit e422ddc, Jonas Quinn updated higan's implementation of the auto- joypad-poll mode. Those fixes were ported to bsnes in commit 39c37ec, but a problem was found with the game "SpellCraft - Aspects of Valor", fixed in bsnes in commit 4f7a269. That fix was back-ported to higan in commit 44cbb88, but that change caused a regression in "Secret of Mana" (issue higan-emu#170). This commit (helpfully provided by Jonas Quinn once again) re-ports the bsnes changes back to higan, and the problems should be solved once and for all. Fixes higan-emu#170.
|
The list of games known to be sensitive to auto-joypad-polling behaviour is not currently online (it used to be on byuu.net), but I have a local copy. Running through the list with the current master (44cbb88):
This PR fixes the problem with Secret of Mana, but it also regresses(?) SpellCraft. Specifically, it introduces the same problem bsnes has (bsnes-emu/bsnes#172) so at least they're consistent now. |
|
After some investigation on the bsnes side, and discussion with Jonas, I believe the new behaviour is how it's supposed to be, so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit e422ddc, Jonas Quinn updated higan's implementation of the auto-joypad-poll mode. Those fixes were ported to bsnes in commit 39c37ec, but a problem was found with the game "SpellCraft - Aspects of Valor", fixed in bsnes in commit 4f7a269. That fix was back-ported to higan in commit 44cbb88, but that change caused a regression in "Secret of Mana" (issue #170).
This commit (helpfully provided by Jonas Quinn once again) re-ports the bsnes changes back to higan, and the problems should be solved once and for all.
Fixes #170.