Skip to content

chore: refactor alias setting in AccountCreateTransaction #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2025
Merged

chore: refactor alias setting in AccountCreateTransaction #2318

merged 6 commits into from
May 12, 2025

Conversation

naydenovn
Copy link
Contributor

@naydenovn naydenovn commented Apr 29, 2025 •
edited
Loading

Description:

Related issue(s):

Fixes #

#2319

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@naydenovn naydenovn self-assigned this Apr 29, 2025
@naydenovn naydenovn requested review from a team as code owners April 29, 2025 07:26
@naydenovn naydenovn requested a review from agadzhalov April 29, 2025 07:26
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...hedera/hashgraph/sdk/AccountCreateTransaction.java 81.81% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...hedera/hashgraph/sdk/AccountCreateTransaction.java 92.25% <81.81%> (ø) 43.00 <3.00> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xivanov
0xivanov approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit e3b6057 into main May 12, 2025
10 checks passed
@0xivanov 0xivanov deleted the extend-set-key-with-alias branch May 12, 2025 11:30
@0xivanov 0xivanov mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xivanov 0xivanov 0xivanov approved these changes

@venilinvasilev venilinvasilev venilinvasilev approved these changes

@agadzhalov agadzhalov Awaiting requested review from agadzhalov agadzhalov is a code owner automatically assigned from hiero-ledger/hiero-sdk-java-maintainers

Assignees

@naydenovn naydenovn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naydenovn @0xivanov @venilinvasilev