Skip to content

Fix acceptance test validation of partial node outage (0.128) #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Fix acceptance test validation of partial node outage (0.128) #11064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/SDKClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@

import com.google.common.base.Stopwatch;
import com.google.protobuf.ByteString;
import com.hedera.hashgraph.sdk.AccountBalanceQuery;
import com.hedera.hashgraph.sdk.AccountCreateTransaction;
import com.hedera.hashgraph.sdk.AccountId;
import com.hedera.hashgraph.sdk.Client;
import com.hedera.hashgraph.sdk.Hbar;
import com.hedera.hashgraph.sdk.TopicDeleteTransaction;
import com.hedera.hashgraph.sdk.TopicId;
import com.hedera.hashgraph.sdk.TopicMessageSubmitTransaction;
import com.hedera.hashgraph.sdk.TransactionReceipt;
import com.hedera.hashgraph.sdk.proto.AccountID;
import com.hedera.hashgraph.sdk.proto.NodeAddress;
Expand All @@ -31,6 +31,7 @@
import java.security.SecureRandom;
import java.time.Duration;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -200,21 +201,32 @@ private void validateClient() throws InterruptedException, TimeoutException {
var network = client.getNetwork();
Map<String, AccountId> validNodes = new LinkedHashMap<>();
var stopwatch = Stopwatch.createStarted();
var invalidNodes = new HashSet<AccountId>();

for (var nodeEntry : network.entrySet()) {
var endpoint = nodeEntry.getKey();
var nodeAccountId = nodeEntry.getValue();

if (validateNode(nodeAccountId)) {
if (validateNode(endpoint, nodeAccountId)) {
validNodes.putIfAbsent(endpoint, nodeAccountId);
log.trace("Added node {} at endpoint {} to list of valid nodes", nodeAccountId, endpoint);
} else {
invalidNodes.add(nodeAccountId);
}

if (validNodes.size() >= acceptanceTestProperties.getMaxNodes()) {
break;
}
}

// Workaround SDK #2317 not propagating the address book when calling setNetwork(), causing TLS to fail
var iterator = validNodes.entrySet().iterator();
while (iterator.hasNext()) {
var next = iterator.next();
if (invalidNodes.contains(next.getValue())) {
iterator.remove();
}
}

log.info("Validated {} of {} endpoints in {}", validNodes.size(), network.size(), stopwatch);
if (validNodes.size() == 0) {
throw new IllegalStateException("All provided nodes are unreachable!");
Expand All @@ -232,21 +244,23 @@ private Client toClient(NodeAddressBook addressBook) {
return configureClient(client).setMirrorNetwork(List.of(acceptanceTestProperties.getMirrorNodeAddress()));
}

private boolean validateNode(AccountId nodeAccountId) {
private boolean validateNode(String endpoint, AccountId nodeAccountId) {
var stopwatch = Stopwatch.createStarted();

try {
new AccountBalanceQuery()
.setAccountId(nodeAccountId)
.setGrpcDeadline(sdkProperties.getGrpcDeadline())
.setNodeAccountIds(List.of(nodeAccountId))
// client.setNetwork(Map.of(endpoint, nodeAccountId)); Enable after SDK #2317 is fixed
new TopicMessageSubmitTransaction()
.setMessage("Mirror Acceptance node " + nodeAccountId + " validation")
.setTopicId(topicId)
.setMaxAttempts(3)
.setMaxBackoff(Duration.ofSeconds(2))
.execute(client, Duration.ofSeconds(10L));
log.info("Validated node {} in {}", nodeAccountId, stopwatch);
.setNodeAccountIds(List.of(nodeAccountId))
.execute(client, Duration.ofSeconds(10L))
.getReceipt(client, Duration.ofSeconds(10L));
log.info("Validated node {} {} in {}", nodeAccountId, endpoint, stopwatch);
return true;
} catch (Exception e) {
log.warn("Unable to validate node {} after {}: {}", nodeAccountId, stopwatch, e.getMessage());
log.warn("Unable to validate node {} {} after {}: {}", nodeAccountId, endpoint, stopwatch, e.getMessage());
}

return false;
Expand Down