Skip to content

Fix acceptance test validation of partial node outage (0.128)#11064

Merged
steven-sheehy merged 1 commit intorelease/0.128from
acceptance-validation-128
Apr 29, 2025
Merged

Fix acceptance test validation of partial node outage (0.128)#11064
steven-sheehy merged 1 commit intorelease/0.128from
acceptance-validation-128

Conversation

@steven-sheehy
Copy link
Copy Markdown
Contributor

Description:

Cherry pick of #11061 to release/0.128. Fix acceptance test validation of partial node outage:

Related issue(s):

Fixes #11060

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Fix acceptance test validation of partial node outage:

* Change validation from balance query to topic submit message since query can sometimes succeed for bad endpoints
* Workaround partial node outage by removing all endpoints for that node account until sdk [#2317](hiero-ledger/hiero-sdk-java#2317) is fixed

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Apr 29, 2025
@steven-sheehy steven-sheehy added this to the 0.128.2 milestone Apr 29, 2025
@steven-sheehy steven-sheehy self-assigned this Apr 29, 2025
@steven-sheehy steven-sheehy requested a review from a team as a code owner April 29, 2025 14:04
@steven-sheehy steven-sheehy requested a review from jnels124 April 29, 2025 14:04
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-23.59% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (69c8417) 35082 33057 94.23%
Head commit (a9d3a58) 49727 (+14645) 35128 (+2071) 70.64% (-23.59%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11064) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Copy Markdown
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilyana-gospodinova bilyana-gospodinova self-requested a review April 29, 2025 14:50
@steven-sheehy steven-sheehy merged commit 3b2afd2 into release/0.128 Apr 29, 2025
30 of 32 checks passed
@steven-sheehy steven-sheehy deleted the acceptance-validation-128 branch April 29, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Something isn't working test Test infrastructure, automated tests required, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants