Skip to content

fix: ensure CancelQuest uses scheduled_job_id #13021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elvangulhan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ensure CancelQuest uses scheduled_job_id #13021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 11 additions & 31 deletions libs/model/src/aggregates/quest/DeleteQuest.command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,60 +1,40 @@
import { Command } from '@hicommonwealth/core';
import * as schemas from '@hicommonwealth/schemas';
import { models } from '../../database';
import { models, sequelize } from '../../database';
import { isSuperAdmin } from '../../middleware';
import { mustExist } from '../../middleware/guards';
import { removeJob } from '../../services';
import { getQuestXpLeaderboardViewName } from '../../utils/quests';
import { removeJob } from '../../services/graphileWorker';

export function DeleteQuest(): Command<typeof schemas.DeleteQuest> {
export function CancelQuest(): Command<typeof schemas.CancelQuest> {
return {
...schemas.DeleteQuest,
...schemas.CancelQuest,
auth: [isSuperAdmin],
secure: true,
body: async ({ payload }) => {
const { quest_id } = payload;

const quest = await models.Quest.scope('withPrivateData').findOne({
where: { id: quest_id },
attributes: ['start_date'],
attributes: ['start_date', 'scheduled_job_id'],
});
mustExist(`Quest "${quest_id}"`, quest);

const actions = await models.XpLog.count({
include: [
{
model: models.QuestActionMeta,
as: 'quest_action_meta',
where: { quest_id },
},
],
});
if (actions > 0)
throw new Error(
`Cannot delete quest "${quest_id}" because it has actions`,
);

let rows: number | undefined;
let rows: [number] | undefined;
await models.sequelize.transaction(async (transaction) => {
if (quest.scheduled_job_id) {
await removeJob({
jobId: quest.scheduled_job_id,
transaction,
});
}
rows = await models.Quest.destroy({
where: { id: quest_id },
transaction,
});
await models.sequelize.query(
`
DROP MATERIALIZED VIEW IF EXISTS "${getQuestXpLeaderboardViewName(quest_id)}";
`,
{ transaction },

rows = await models.Quest.update(
{ end_date: sequelize.literal('NOW()') },
{ where: { id: quest_id } },
);
});

return rows ? rows > 0 : false;
return rows ? rows[0] > 0 : false;
},
};
}