Skip to content

HHH-19846 Drop JUnit 4 usage #11113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

HHH-19846 Drop JUnit 4 usage #11113

wants to merge 53 commits into from
+10,433 −10,216

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Oct 11, 2025 •
edited by hibernate-github-bot bot
Loading

Dropped Junit4 in packages:

  • org.hibernate.orm.test.annotations.configuration
  • org.hibernate.orm.test.annotations.derivedidentities.e1.b
  • org.hibernate.orm.test.annotations.derivedidentities.e1.b.specjmapid
  • org.hibernate.orm.test.annotations.derivedidentities.e1.b.specjmapid.lazy
  • org.hibernate.orm.test.annotations.derivedidentities.e1.c
  • org.hibernate.orm.test.annotations.derivedidentities.e4.b
  • org.hibernate.orm.test.annotations.derivedidentities.e5.c
  • org.hibernate.orm.test.annotations.duplicatedgenerator
  • org.hibernate.orm.test.annotations.entity
  • org.hibernate.orm.test.annotations.enumerated.mapkey
  • org.hibernate.orm.test.annotations.enumerated.ormXml
  • org.hibernate.orm.test.annotations.fetch
  • org.hibernate.orm.test.annotations.fetchprofile
  • org.hibernate.orm.test.annotations.formula
  • org.hibernate.orm.test.annotations.idmanytoone
  • org.hibernate.orm.test.annotations.idmanytoone.alphabetical
  • org.hibernate.orm.test.annotations.immutable
  • org.hibernate.orm.test.annotations.index.jpa
  • org.hibernate.orm.test.annotations.indexcoll
  • org.hibernate.orm.test.annotations.indexcoll.eager
  • org.hibernate.orm.test.annotations.join
  • org.hibernate.orm.test.annotations.loader
  • org.hibernate.orm.test.annotations.lob
  • org.hibernate.orm.test.annotations.lob.hhh4635
  • org.hibernate.orm.test.annotations.lob.locator
  • org.hibernate.orm.test.annotations.manytomany
  • org.hibernate.orm.test.annotations.manytomany.defaults

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-19846

@dreab8 dreab8 force-pushed the HHH-19846 branch 2 times, most recently from 45025a8 to 239c0d9 Compare October 11, 2025 08:54
@dreab8 dreab8 force-pushed the HHH-19846 branch 2 times, most recently from 8d83cd4 to 7acfe10 Compare October 11, 2025 09:20
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
...test/java/org/hibernate/orm/test/annotations/uniqueconstraint/UniqueConstraintUnitTests.java
assertThat( tableA != null && tableB != null )
.describedAs( "Could not find the expected tables." )
.isTrue();
assertThat( tableA.getUniqueKeys().values().iterator().next().getName() )

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
tableA
Loading
may be null at this access because of
this
Loading
assignment.
...test/java/org/hibernate/orm/test/annotations/uniqueconstraint/UniqueConstraintUnitTests.java
.describedAs( "Could not find the expected tables." )
.isTrue();
assertThat( tableA.getUniqueKeys().values().iterator().next().getName() )
.isNotEqualTo( tableB.getUniqueKeys().values().iterator().next().getName() );

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
tableB
Loading
may be null at this access because of
this
Loading
assignment.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
...rnate-core/src/test/java/org/hibernate/orm/test/associations/CompositeIdAssociationTest.java
Comment on lines +37 to +53
PersonAddress _personAddress = scope.fromTransaction( entityManager -> {
Person person1 = new Person( "ABC-123" );
Person person2 = new Person( "DEF-456" );

Address address1 = new Address("12th Avenue", "12A", "4005A");
Address address2 = new Address("18th Avenue", "18B", "4007B");
Address address1 = new Address( "12th Avenue", "12A", "4005A" );
Address address2 = new Address( "18th Avenue", "18B", "4007B" );

entityManager.persist(person1);
entityManager.persist(person2);
entityManager.persist( person1 );
entityManager.persist( person2 );

entityManager.persist(address1);
entityManager.persist(address2);
entityManager.persist( address1 );
entityManager.persist( address2 );

PersonAddress personAddress = new PersonAddress(person1, address1);
entityManager.persist(personAddress);
PersonAddress personAddress = new PersonAddress( person1, address1 );
entityManager.persist( personAddress );
return personAddress;
});
} );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'PersonAddress _personAddress' is never read.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2025
View reviewed changes
hibernate-core/src/test/java/org/hibernate/orm/test/comments/UseSqlCommentTest.java
Comment on lines 97 to 100
"select new " + TestEntity.class.getName() + "(id, '"
+ appendLiteral.replace( "'", "''" )
+ "') from TestEntity where id=:where_id",
+ appendLiteral.replace( "'", "''" )
+ "') from TestEntity where id=:where_id",

Check failure

Code scanning / CodeQL

Query built by concatenation with a possibly-untrusted string High test

Query built by concatenation with
this expression
Loading
, which may be untrusted.
.../org/hibernate/orm/test/component/cascading/collection/CascadeToComponentCollectionTest.java
session.close();
Definition d = new Definition();
scope.inTransaction( session -> {
Value value1 = new Value( d );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Value value1' is never read.
hibernate-core/src/test/java/org/hibernate/orm/test/compositeelement/Parent.java
Parent() {}
public Parent(String name) {
this.name = name;
}
/**
* @return Returns the children.
*/
public Collection getChildren() {
public Collection<Child> getChildren() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note test

getChildren exposes the internal representation stored in field children. The value may be modified
after this call to getChildren
Loading
.
getChildren exposes the internal representation stored in field children. The value may be modified
after this call to getChildren
Loading
.
getChildren exposes the internal representation stored in field children. The value may be modified
after this call to getChildren
Loading
.
getChildren exposes the internal representation stored in field children. The value may be modified
after this call to getChildren
Loading
.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 22, 2025
View reviewed changes
hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/identity/MyEntity.java
@@ -47,19 +47,19 @@
this.sibling = sibling;
}

public Set getNonInverseChildren() {
public Set<MyChild> getNonInverseChildren() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note generated test

getNonInverseChildren exposes the internal representation stored in field nonInverseChildren. The value may be modified
after this call to getNonInverseChildren
Loading
.
hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/identity/MyEntity.java
this.nonInverseChildren = nonInverseChildren;
}

public Set getInverseChildren() {
public Set<MyChild> getInverseChildren() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note generated test

getInverseChildren exposes the internal representation stored in field inverseChildren. The value may be modified
after this call to getInverseChildren
Loading
.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2025
View reviewed changes
hibernate-core/src/test/java/org/hibernate/orm/test/graph/EntityGraphsTest.java
}

@Test
public void testNullsEqual() {
Assert.assertTrue( EntityGraphs.areEqual( (EntityGraph<GraphParsingTestEntity>) null, (EntityGraph<GraphParsingTestEntity>) null ) );
public void testNullsEqual(EntityManagerFactoryScope scope) {

Check notice

Code scanning / CodeQL

Useless parameter Note test

The parameter 'scope' is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dreab8