Make BytecodeEnhancedTestEngine non-discoverable by default #10491
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by removing the corresponding entry from the META-INF/services/org.junit.platform.engine.TestEngine
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
mbellade
reviewed
Jul 9, 2025
I sure hope so 😃, at least it shows it ok from the IDE, and if I run from the terminal with Gradle, I get: so "all good" it seems. let me check that MySQL build... |
since there's the enhanced prefix in the test ^ |
|
Great, not sure we're getting this failure here though, I'll re-run the checks. But anyway, +1 from me to do this: I don't think we've advertised this feature being enabled anywhere, but I doubt anyone but us is using it in tests and expects it to be available by default. |
|
Do we still have a problem with the JUnit version? It seems that running the JPA TCK works fine now, so unless it's broken, no touching :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the corresponding entry from the
META-INF/services/org.junit.platform.engine.TestEnginewe won't let JUnit pick up this engine by default, so in places like TCK or elsewhere where we do not need the@BytecodeEnhancedtests, we won't cause a problem if there is a JUnit version mismatch.My concern is that this is a published jar, and this breaks the "original" behaviour 😖
@beikov WDYT?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.