Skip to content

Conversation

@hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jun 2, 2025

Related

We likely don't want to hard-code anything, but let's confirm manualChunks allows merging client reference chunks based on users own heuristics if needed.

todo

  • vendor chunks
  • merge client references
    • it looks like export names is not preserved after merge? latest VIte 6 doesn't have chunk: merge allow-extension modules rollup/rollup#5891 yet. It works after rollup overrides.
    • actually it's still broken when there's export conflict since client reference manifest is picking up a wrong chunk.
  • test

example

image

Copy link
Owner Author

hi-ogawa commented Jun 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa force-pushed the 06-02-chore_rsc_custom_client_chunks branch 5 times, most recently from 6038a48 to d7e2a13 Compare June 2, 2025 08:29
@hi-ogawa hi-ogawa force-pushed the 05-26-refactor_rsc_load_client_reference_without_vite_preload branch from b49c01c to 2fea96a Compare June 2, 2025 08:29
@hi-ogawa hi-ogawa force-pushed the 06-02-chore_rsc_custom_client_chunks branch from d7e2a13 to 4297c64 Compare June 2, 2025 08:38
@hi-ogawa hi-ogawa changed the title chore(rsc): custom client chunks chore(rsc): custom client chunk example Jun 2, 2025
@hi-ogawa hi-ogawa force-pushed the 06-02-chore_rsc_custom_client_chunks branch from 4297c64 to 1ba70c3 Compare June 2, 2025 08:57
@hi-ogawa hi-ogawa marked this pull request as ready for review June 2, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants