refactor(fullstack): use virtual runtime entry #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
reviewed
Oct 28, 2025
packages/fullstack/src/plugin.ts
Outdated
Comment on lines
843
to
862
| // virtual:fullstack/runtime | ||
| function runtimeUtils() { | ||
| return /* js */ ` | ||
| export function mergeAssets(...args) { | ||
| const js = uniqBy(args.flatMap((h) => h.js), (a) => a.href); | ||
| const css = uniqBy(args.flatMap((h) => h.css), (a) => a.href); | ||
| const entry = args.filter((arg) => arg.entry)?.[0]?.entry; | ||
| const raw = { entry, js, css }; | ||
| return { ...raw, merge: (...args$1) => mergeAssets(raw, ...args$1) }; | ||
| } | ||
| function uniqBy(array, key) { | ||
| const seen = new Set(); | ||
| return array.filter((item) => { | ||
| const k = key(item); | ||
| if (seen.has(k)) return false; | ||
| seen.add(k); | ||
| return true; | ||
| }); | ||
| }`; | ||
| } |
There was a problem hiding this comment.
Hmm, however copying the code string here is not ideal. Let me think.
hi-ogawa
reviewed
Oct 28, 2025
Comment on lines
+374
to
+379
| if (id === "\0virtual:fullstack/runtime") { | ||
| return fs.readFileSync( | ||
| path.join(import.meta.dirname, "runtime.js"), | ||
| "utf-8", | ||
| ); | ||
| } |
There was a problem hiding this comment.
@pi0 How about this? I think nft style bundling supports something like this, but is nitro itself bundled to support this?
There was a problem hiding this comment.
This will cause pulling in extra dependencies to dist/node_modules + extra dist as nft cannot tree-shake code by imports anymore. I have noticed plugin depends on srvx 0.8 for example it was tracing both 0.8 and 0.9!
Maybe later we can have a build step to convert runtime.ts into inlined code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: In nitro, we bundle most of plugin dependencies. This causes an issue with using fullastack plugin in end projects:
This PR fixes the limitation by exposing small set of runtime utils as a virtual entry instead.
I have preserved other
/runtimesubpath for external usage without breaking change.