-
Notifications
You must be signed in to change notification settings - Fork 7
[fullstack] Add experimental CSS deduplication between server and client builds #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: hi-ogawa <[email protected]>
Co-authored-by: hi-ogawa <[email protected]>
Co-authored-by: hi-ogawa <[email protected]>
Co-authored-by: hi-ogawa <[email protected]>
|
@copilot |
Co-authored-by: hi-ogawa <[email protected]>
Done! Modified the implementation to mutate The client entry now includes both CSS files in the manifest:
This ensures the client build is aware of the CSS dependencies from the server build. (commit: will be in next message after push completes)
Done in commit c4c7b01! Modified the implementation to mutate The client entry now includes both CSS files in the manifest:
This ensures the client build is aware of the CSS dependencies from the server build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do following
- inline
cssDeduplicationPlugininsideassetsPlugin - fix type error
chunk.viteMetadata.importedCss = [...newImportedCss]; - ensure ci passes
Co-authored-by: hi-ogawa <[email protected]>
Done in this commit:
Manifest still correctly includes both CSS files as expected. |
Changes
Addressed feedback to:
cssDeduplicationPlugindirectly insideassetsPluginarray(chunk.viteMetadata as { importedCss: Set<string> }).importedCss = newImportedCssThe functionality remains the same - CSS deduplication works correctly and the manifest includes both CSS files as expected.
Original prompt
Fixes #1244
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.