Provide the JSON library as a provided dependency #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the scope on the JSON library to the 'provided' scope, since the same org.json API is available from Android.
Almost all the tests passed on my local machine's JVM and the Android device, but I did have to tell the Android device where to find the testing server.
The one test that fails after these changes is com.goebl.david.TestWebb_Ssl.testHttpsInvalidCertificate, which fails due to "junit.framework.AssertionFailedError: expected: but was:". I ran the test on a device running Android 6.0.1. Perhaps the Android system is more explicit about what exceptions it throws when it encounters an invalid certificate than it was in older versions of Android? Alternatively, maybe that specific test can be changed to check if the thrown exception is a descendant class of IOException. Any thoughts?