Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demofix #42

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Demofix #42

merged 3 commits into from
Dec 5, 2024

Conversation

samvang
Copy link
Collaborator

@samvang samvang commented Dec 4, 2024

make demo formula change to []p in the cases k and gl to avoid stack overflow

@samvang samvang requested a review from hferee December 4, 2024 15:02
@hferee hferee merged commit b741b5d into main Dec 5, 2024
3 of 4 checks passed
@hferee
Copy link
Owner

hferee commented Dec 5, 2024

Merged. Can you check that it does what you expect?
The formula doesn't seem to be reset every time.

@samvang
Copy link
Collaborator Author

samvang commented Dec 5, 2024

Great, thank you. The formula indeed only resets when switching to a modal logic if the value of the input formula is still equal to the default formula. This is what I wanted: If it always resets, then one would get the undesirable behavior that a user has entered their own formula for IL, then wants to calculate the same formula for K, but the form jumps back to the default modal logic formula...

@samvang samvang deleted the demofix branch December 5, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants