Skip to content

fix(cli): preload render.js once in renderLocal test suite (Windows CI) #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrusso1020 merged 1 commit into from
May 7, 2026
+14 −12
Merged

fix(cli): preload render.js once in renderLocal test suite (Windows CI) #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions packages/cli/src/commands/render.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@ vi.mock("../telemetry/events.js", () => ({

describe("renderLocal browser GPU config", () => {
const savedEnv = new Map<string, string | undefined>();
// Pre-resolve once. The first dynamic `import("./render.js")` in this file
// takes >5 s on Windows runners (cold module load) — long enough to blow
// vitest's default 5 s timeout in whichever test happens to be first. When
// that test times out, its leaked late `createRenderJob` call lands AFTER
// the next test's `beforeEach` clears `producerState.createdJobs`, shifting
// index 0 and corrupting unrelated assertions. Importing once in
// `beforeAll` keeps every test fast and isolated.
let renderLocal: typeof import("./render.js").renderLocal;
let resolveBrowserGpuForCli: typeof import("./render.js").resolveBrowserGpuForCli;

beforeAll(async () => {
({ renderLocal, resolveBrowserGpuForCli } = await import("./render.js"));
});

function setEnv(key: string, value: string) {
savedEnv.set(key, process.env[key]);
Expand Down Expand Up @@ -54,7 +67,6 @@ describe("renderLocal browser GPU config", () => {
it("passes an explicit software override for --no-browser-gpu even when env requests hardware", async () => {
setEnv("PRODUCER_BROWSER_GPU_MODE", "hardware");

const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -73,7 +85,6 @@ describe("renderLocal browser GPU config", () => {
});

it("forwards browserGpuMode='auto' into producer config (probe-then-choose)", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -92,7 +103,6 @@ describe("renderLocal browser GPU config", () => {
});

it("passes an explicit hardware override for default local browser GPU", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -110,9 +120,7 @@ describe("renderLocal browser GPU config", () => {
});
});

it("resolves browser GPU from CLI flags, Docker mode, and env fallback", async () => {
const { resolveBrowserGpuForCli } = await import("./render.js");

it("resolves browser GPU from CLI flags, Docker mode, and env fallback", () => {
// Default (no flag, no env): auto — engine probes and chooses.
expect(resolveBrowserGpuForCli(false, undefined, undefined)).toBe("auto");
// Env override
Expand All @@ -128,7 +136,6 @@ describe("renderLocal browser GPU config", () => {
});

it("forwards parsed --variables payload to createRenderJob", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -144,7 +151,6 @@ describe("renderLocal browser GPU config", () => {
});

it("forwards format: png-sequence through to createRenderJob", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/frames", {
fps: 30,
quality: "standard",
Expand All @@ -159,7 +165,6 @@ describe("renderLocal browser GPU config", () => {
});

it("omits variables from createRenderJob when not provided", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -174,7 +179,6 @@ describe("renderLocal browser GPU config", () => {
});

it("forwards entryFile to createRenderJob when --composition is set", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -190,7 +194,6 @@ describe("renderLocal browser GPU config", () => {
});

it("omits entryFile from createRenderJob when --composition is not set", async () => {
const { renderLocal } = await import("./render.js");
await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
quality: "standard",
Expand All @@ -211,7 +214,6 @@ describe("renderLocal browser GPU config", () => {
.mockImplementation((code?: string | number | null): never => {
throw new Error(`process.exit:${code ?? ""}`);
});
const { renderLocal } = await import("./render.js");

await renderLocal("/tmp/project", "/tmp/out.mp4", {
fps: 30,
Expand Down
Loading