Skip to content

fix(cli): use bun in command hints#632

Merged
jrusso1020 merged 1 commit intoheygen-com:mainfrom
kiyeonjeon21:fix/cli-bun-command-hints
May 7, 2026
Merged

fix(cli): use bun in command hints#632
jrusso1020 merged 1 commit intoheygen-com:mainfrom
kiyeonjeon21:fix/cli-bun-command-hints

Conversation

@kiyeonjeon21
Copy link
Copy Markdown
Contributor

Summary

  • Use the Studio package's bun dev script when hyperframes preview runs from the monorepo source path.
  • Update stale CLI missing-build guidance from pnpm commands to bun commands.
  • Leave release/packaging-related pnpm usage untouched, since that appears to be part of the publish workflow.

Why

I noticed a few user-facing CLI paths still referenced pnpm while checking the repo setup. CONTRIBUTING.md and AGENTS.md describe bun as the workspace package manager, so this keeps those small hints aligned with the documented development flow.

Validation

  • bunx oxfmt --check packages/cli/src/commands/play.ts packages/cli/src/commands/preview.ts packages/cli/src/server/studioServer.ts
  • bunx oxlint packages/cli/src/commands/play.ts packages/cli/src/commands/preview.ts packages/cli/src/server/studioServer.ts
  • bun run --filter @hyperframes/cli typecheck
  • bun run --filter @hyperframes/cli test -- src/server/studioServer.test.ts

Copy link
Copy Markdown
Collaborator

@jrusso1020 jrusso1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

Approve. Trivial, correct alignment of user-facing CLI hints with the documented bun-based workflow (CLAUDE.md:23 and AGENTS.md:65 both call out bun as the workspace package manager and explicitly say "NOT pnpm"). Each replacement is verified against the corresponding package.json script.

Verified:

  • packages/studio/package.json defines "dev": "vite"spawn("bun", ["run", "dev"]) is equivalent to the previous pnpm exec vite.
  • packages/player/package.json defines "build": "tsup"bun run --cwd packages/player build builds the player as expected.
  • Root package.json defines "build" (orchestrates all packages) → bun run build is the correct root-level build.
  • Author's stated scope is right: pnpm references in installerDetection.ts / autoUpdate.ts are correctly left alone — those detect end-user global installs and pnpm-installed users still need the pnpm add -g upgrade hint.

Key Concerns

(none)

Test Coverage

No test changes needed — these are message-string and command-name updates. The studioServer HTML snippet and the play/preview error paths are infrequent fallback branches; existing tests don't (and don't need to) snapshot the literal text.

Nits / Future

  • packages/cli/src/commands/play.ts:28,36 and packages/cli/src/server/studioServer.ts:412bun run build is ambiguous about the working directory (it's a root-level script). The original pnpm build had the same ambiguity, so this isn't a regression, but contributor-facing hints could be made explicit, e.g. bun run build from the monorepo root or bun run --cwd <repo-root> build. Pure copy.
  • packages/cli/src/commands/preview.ts:262runLocalStudioMode still spawns npx vite, which is intentional (this path runs against a user-installed @hyperframes/studio, not the monorepo) and consistent with using a universally available launcher. Just flagging that the pnpmbun cleanup is correctly not extended here; no action needed.

@jrusso1020 jrusso1020 merged commit a327e13 into heygen-com:main May 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants