Skip to content

fix(studio): timeline seekbar focus blocks NLE keyboard shortcuts #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguel-heygen merged 2 commits into from
May 30, 2026
Merged

fix(studio): timeline seekbar focus blocks NLE keyboard shortcuts #1137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a7adb
fix(studio): blur seekbar after seek so NLE shortcuts resume
miguel-heygen May 30, 2026
3866214
fix(studio): blur color slider on pointer release (sister bug)
miguel-heygen May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/studio/src/player/components/PlayerControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ const SeekBar = memo(function SeekBar({
aria-valuemin={0}
aria-valuemax={Math.round(duration)}
aria-valuenow={0}
className={`min-w-[96px] flex-1 h-6 flex items-center group ${
className={`min-w-[96px] flex-1 h-6 flex items-center group outline-none focus-visible:ring-1 focus-visible:ring-white/30 focus-visible:rounded ${
disabled ? "cursor-not-allowed opacity-50" : "cursor-pointer"
}`}
style={{ touchAction: "none" }}
Expand Down
3 changes: 2 additions & 1 deletion packages/studio/src/player/components/Timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,8 @@ export const Timeline = memo(function Timeline({
>
<div
ref={scrollRef}
className={`${zoomMode === "fit" ? "overflow-x-hidden" : "overflow-x-auto"} overflow-y-auto h-full`}
tabIndex={-1}
className={`${zoomMode === "fit" ? "overflow-x-hidden" : "overflow-x-auto"} overflow-y-auto h-full outline-none`}
onDragOver={handleAssetDragOver}
onDragLeave={() => setIsDragOver(false)}
onDrop={handleAssetDrop}
Expand Down
1 change: 1 addition & 0 deletions packages/studio/src/player/components/useSeekBarDrag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export function useSeekBarDrag(
window.removeEventListener("pointercancel", onUp);
document.removeEventListener("visibilitychange", onVisibilityChange);
window.removeEventListener("blur", cleanup);
target.blur();
};
const onUp = (ev: PointerEvent) => {
if (ev.pointerId !== pointerId) return;
Expand Down
Loading