Skip to content

Conversation

tahosa
Copy link

@tahosa tahosa commented Jul 30, 2024

Update the Ubuntu Base to 24.04 Noble Numbat
Update the NodeJS Base to 22.x and update packages to compatible versions
Update NodeJS matrix for Github Actions to supported versions
Update interaction with rdiff-backup increment list changes since 2.2.10a

Ref: #553

Copy link
Contributor

@shinyone shinyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shadow8472
Copy link

Shadow8472 commented Aug 12, 2025

I'm glad to see fresh activity on MineOS.

Looks like the conflict is over both branches addressing OpenJDK 21 support in /Dockerfile.
Of note, hexparrot:master drops OpenJDK 17. Is there a reason for keeping it?

EDIT:
I just tried manually merging the changes and it failed to build. Packages are again depreciated and npm threw a long error blaming Make (as far as I can tell, anyway).

@tahosa
Copy link
Author

tahosa commented Aug 12, 2025

@Shadow8472 I'll get this updated again shortly. At the time I originally did this, there was some discussion online that I found where certain versions of Minecraft weren't working properly with 21 (IIRC it was v1.12.x to 1.16.x). It looks like that has probably cleared up, so I will also drop JDK17 as part of this.

@tahosa tahosa force-pushed the update-node-22 branch 2 times, most recently from 776ecbc to ce5a252 Compare August 12, 2025 14:43
Update the Ubuntu Base to 24.04 Noble Numbat
Update the NodeJS Base to 22.x
Update interaction with rdiff-backup increment list changes since 2.2.10a
@tahosa
Copy link
Author

tahosa commented Aug 12, 2025

@Shadow8472 This should now be updated. The docker build and tests work for me on my fork and on my local Ubuntu 24.04 machine. My IDE auto-removed trailing whitespace in some of the files, but I can remove those changes if you would prefer.

var OWNER_CREDS = {
uid: 1001,
gid: 121
gid: 118
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Github Ubuntu runner changed it's default GID to 118. I'm trying to find their changelog that documents this, but haven't found it so far. This comes from running id in the action runner on my fork.

@Shadow8472
Copy link

Shadow8472 commented Aug 12, 2025

Sweet! The container built for me with no issues on Rocky Linux 9.6/Podman 5.4.0, and I was able to log in after setting USE_HTTPS to false (I use Caddy). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants