-
Notifications
You must be signed in to change notification settings - Fork 179
Update Ubuntu and NodeJS Bases #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm glad to see fresh activity on MineOS. Looks like the conflict is over both branches addressing OpenJDK 21 support in EDIT: |
@Shadow8472 I'll get this updated again shortly. At the time I originally did this, there was some discussion online that I found where certain versions of Minecraft weren't working properly with 21 (IIRC it was v1.12.x to 1.16.x). It looks like that has probably cleared up, so I will also drop JDK17 as part of this. |
776ecbc
to
ce5a252
Compare
Update the Ubuntu Base to 24.04 Noble Numbat Update the NodeJS Base to 22.x Update interaction with rdiff-backup increment list changes since 2.2.10a
@Shadow8472 This should now be updated. The docker build and tests work for me on my fork and on my local Ubuntu 24.04 machine. My IDE auto-removed trailing whitespace in some of the files, but I can remove those changes if you would prefer. |
var OWNER_CREDS = { | ||
uid: 1001, | ||
gid: 121 | ||
gid: 118 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Github Ubuntu runner changed it's default GID to 118. I'm trying to find their changelog that documents this, but haven't found it so far. This comes from running id
in the action runner on my fork.
Sweet! The container built for me with no issues on Rocky Linux 9.6/Podman 5.4.0, and I was able to log in after setting |
Update the Ubuntu Base to 24.04 Noble Numbat
Update the NodeJS Base to 22.x and update packages to compatible versions
Update NodeJS matrix for Github Actions to supported versions
Update interaction with rdiff-backup increment list changes since 2.2.10a
Ref: #553