feat: upgrade to TypeScript and @oclif/core 4.x #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was initially an attempt to bring this plugin in alignment with our current CLI versions, by migrating to
@oclif/core2.x and TypeScript. The way we planned it though, prove to be difficult:heroku-cli-utilto replace a legacy dependency on@heroku-cli/plugin-pg-v5that's associated with most of the 3PP vulns needed to be fixed.heroku-cli-utilinitially seemed to be not necessary, but after migrating one command for testing, we discovered the lib functions weren't working. Fixing that turned into its own rabbit hole, but the result is on this PR.heroku-cli-utiluse@oclif/core4.x and ESM and that in turn, generated a lot of problems with unresolvable dependencies in this repository.This draft PR has both the TypeScript config and the example command migrated, aligned with
heroku-cli-utilon@oclif/core4.x. And everything works when running the command through./bin/run.There's a document that @k80bowman put up to discuss options for moving forward this migration: see here.
Testing
npm installandnpm run build.Screenshots (if applicable)
SOC2 Compliance
Gus Work Item: W-18004666 (Heroku internal)